Upgrade jscodeshift to 0.5.0 and all other deps #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webpack-bot
added
PR: unreviewed
PR: CI-not-ok
PR: CI-ok
and removed
PR: CI-not-ok
labels
|
Hi @dfederm, would you mind to do a rebase from master? We just a merged a PR with some changes to the |
montogeek
reviewed
Mar 8, 2018
| @@ -2,7 +2,8 @@ | |||
|
|
|||
| exports[`top-scope transforms correctly using "top-scope-0" data 1`] = ` | |||
| "var test = 'me'; | |||
| module.exports = {}" | |||
| module.exports = {} | |||
There was a problem hiding this comment.
Such a strange change from Jest
evenstensberg
approved these changes
Mar 8, 2018
sendilkumarn
approved these changes
Mar 8, 2018
ematipico
approved these changes
Mar 8, 2018
ematipico
reviewed
Mar 8, 2018
package.json
Outdated
| @@ -99,7 +99,8 @@ | |||
| "p-lazy": "^1.0.0", | |||
| "prettier": "^1.5.3", | |||
| "resolve-cwd": "^2.0.0", | |||
| "supports-color": "^5.2.0", | |||
| "supports-color": "^5.3.0", | |||
| "uglifyjs-webpack-plugin": "^1.2.2", | |||
There was a problem hiding this comment.
Ah! Almost nobody noticed it. 👀 😆
There was a problem hiding this comment.
Woops, a bad rebase on my end. It got removed in #309 and I merged badly. Will remove.
ematipico
suggested changes
Mar 8, 2018
package.json
Outdated
| @@ -110,16 +111,16 @@ | |||
| "webpack": "^4.0.0-beta.1" | |||
There was a problem hiding this comment.
Could you update this to be ^4.0.0?
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-approved
PR: reviewed-changes-requested
labels
dhruvdutt
approved these changes
Mar 8, 2018
ematipico
approved these changes
Mar 8, 2018
|
@ev1stensberg Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
|
@ev1stensberg The tests look fine, but there are code style issue in your Pull Request. Please review the following: See complete report here. |
This was referenced Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Dependencies upgrade
Did you add tests for your changes?
Nothing to add. Adjusted a snapshot as needed though.
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
No.