Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generators) Use webpack 4 version of extract-text-webpack-plugin #322

Closed

Conversation

montogeek
Copy link
Member

What kind of change does this PR introduce?
Bugfix, fixes #320

Did you add tests for your changes?
No, but tests pass locally

Summary
Updated extract-text-webpack-plugin to use latest version under next dist-tag which is compatible with webpack 4, once it is stable we should remove this change and use latest dist-tag.

@webpack-bot
Copy link

@montogeek Please review the following output log for errors:

> webpack-cli@2.0.10 travis:integration /home/travis/build/webpack/webpack-cli
> nyc jest && npm run reportCoverage

 PASS  lib/utils/resolve-packages.spec.js (13.791s)
 PASS  lib/utils/is-local-path.spec.js (16.271s)
 PASS  lib/utils/package-manager.spec.js (20.65s)
 PASS  lib/utils/npm-exists.spec.js (20.103s)
 PASS  lib/generators/loader-generator.test.js (28.712s)
 PASS  lib/init/transformations/top-scope/top-scope.test.js (13.695s)
 PASS  lib/migrate/bannerPlugin/bannerPlugin.test.js (10.629s)
 PASS  lib/init/transformations/output/output.test.js (33.06s)
 PASS  lib/init/transformations/mode/mode.test.js (32.821s)
 PASS  lib/migrate/extractTextPlugin/extractTextPlugin.test.js
 PASS  lib/init/transformations/performance/performance.test.js (35.617s)
 PASS  lib/migrate/resolve/resolve.test.js
 PASS  lib/utils/ast-utils.test.js (39.36s)
 PASS  lib/init/transformations/resolve/resolve.test.js (38.871s)
 PASS  lib/migrate/index.test.js (38.174s)
 PASS  lib/init/transformations/watch/watchOptions.test.js (38.773s)
 PASS  lib/init/transformations/watch/watch.test.js (38.849s)
 PASS  lib/init/transformations/devtool/devtool.test.js (39.213s)
 PASS  lib/init/transformations/resolveLoader/resolveLoader.test.js (38.583s)
 PASS  lib/migrate/removeDeprecatedPlugins/removeDeprecatedPlugins.test.js (38.875s)
  ● Console

    console.log lib/migrate/removeDeprecatedPlugins/removeDeprecatedPlugins.js:37
      
      Please remove deprecated plugins manually. 
      See https://webpack.js.org/guides/migrating/ for more information.
    console.log lib/migrate/removeDeprecatedPlugins/removeDeprecatedPlugins.js:37
      
      Please remove deprecated plugins manually. 
      See https://webpack.js.org/guides/migrating/ for more information.
    console.log lib/migrate/removeDeprecatedPlugins/removeDeprecatedPlugins.js:37
      
      Please remove deprecated plugins manually. 
      See https://webpack.js.org/guides/migrating/ for more information.

 PASS  lib/init/transformations/node/node.test.js (25.959s)
 PASS  lib/migrate/outputPath/outputPath.test.js (9.548s)
 PASS  lib/init/transformations/plugins/plugins.test.js (39.019s)
 PASS  lib/init/transformations/devServer/devServer.test.js (39.426s)
 PASS  lib/migrate/loaderOptionsPlugin/loaderOptionsPlugin.test.js (39.061s)
 PASS  lib/init/transformations/context/context.test.js (39.893s)
 PASS  lib/migrate/uglifyJsPlugin/uglifyJsPlugin.test.js (20.309s)
 PASS  lib/init/transformations/entry/entry.test.js (40.676s)
 PASS  lib/init/transformations/stats/stats.test.js (40.68s)
 PASS  lib/init/transformations/module/module.test.js (41.51s)
 PASS  lib/migrate/removeJsonLoader/removeJsonLoader.test.js (39.7s)
 PASS  lib/init/transformations/target/target.test.js (40.005s)
 PASS  lib/init/transformations/externals/externals.test.js (41.184s)
 PASS  lib/migrate/loaders/loaders.test.js (41.148s)
 PASS  lib/init/index.test.js (42.837s)
 PASS  lib/utils/npm-packages-exists.spec.js (44.152s)
 PASS  lib/init/transformations/other/other.test.js (44.372s)
 PASS  test/BinTestCases.test.js (177.377s)
�[999D�[K
=============================== Coverage summary ===============================
Statements   : 72.74% ( 1278/1757 )
Branches     : 58.11% ( 509/876 )
Functions    : 70.11% ( 312/445 )
Lines        : 72.68% ( 1266/1742 )
===

See complete report here.

@ematipico
Copy link
Contributor

We have to remember to revert this change once the actual @next version will released on npm

@evenstensberg
Copy link
Member

Fixed this in #323

@montogeek montogeek closed this Mar 8, 2018
@montogeek montogeek deleted the feature/update-extract-text-plugin branch March 8, 2018 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack init trying to use unsupported extract-text-webpack-plugin
4 participants