chore(pkg): explicitly include files for release #349

rgbkrk · 2018-03-15T17:05:58Z

What kind of change does this PR introduce?

Build related change

Did you add tests for your changes?

N/A

If relevant, did you update the documentation?

N/A

Summary

When running flow in a project that uses webpack-cli, the latest release is causing flow to choke on a non-valid json file:

> flow

Launching Flow server for /Users/kylek/code/src/github.com/nteract/nteract-ext
Spawned flow server (pid=10402)
Logs will go to /private/tmp/flow/zSUserszSkylekzScodezSsrczSgit.luolix.topzSnteractzSnteract-ext.log
Monitor logs will go to /private/tmp/flow/zSUserszSkylekzScodezSsrczSgit.luolix.topzSnteractzSnteract-ext.monitor_log
Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ node_modules/webpack-cli/.nyc_output/8f27269b188e61a59bbf5827de818c30.json:1:1

Unexpected end of input

     1│

Since that file shouldn't be part of the release, I added the .nyc_output directory to the npm ignore.

Does this PR introduce a breaking change?

Nope.

jsf-clabot · 2018-03-15T17:05:59Z

All committers have signed the CLA.

dhruvdutt

Please sign CLA and use commitlint for linting commit messages. You can use git cz for an interactive commit or use one of these.

evenstensberg

Thanks!

rgbkrk · 2018-03-15T18:08:50Z

@dhruvdutt would you say this is a chore or a fix?

dhruvdutt · 2018-03-15T18:10:29Z

chore

evenstensberg

Heyo, didn't read this. Seems to be another PR for this #354 . Could you do the thing I mentioned there? First one to implement gets a lgtm 😄

rgbkrk · 2018-03-20T20:01:11Z

Rebased with requested commit style.

dhruvdutt · 2018-03-20T20:03:23Z

@rgbkrk Do check what Even has mentioned in his review on #354

rgbkrk · 2018-03-20T20:05:13Z

Yeah I just added on the ones @ev1stensberg explicitly mentioned, looking into what else is misc though I'm sure you'll be able to rattle off which you don't want more easily as a maintainer.

Do you want docs in the packaged release?

Looking again, jsdoc.json was already in there, so I'm rebasing again.

dhruvdutt

LGTM.

dhruvdutt · 2018-03-20T20:08:44Z

@rgbkrk docs are already included in npmignore file.
You can also clean up things from npmignore that are already included in .gitignore like .vscode

rgbkrk · 2018-03-20T20:14:22Z

Alright, I've organized the npmignore more like the gitignore.

dhruvdutt

Uh! I might not have explained it in the best way.
I meant to clean up or not include things that are already listed in gitignore. For instance, .vscode is currently mentioned in both npmignore and gitignore but if it's in gitignore then it won't be in version control or on GitHub in the first place hence we don't need to mention it in npmignore.

webpack-bot · 2018-03-20T20:29:51Z

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

rgbkrk · 2018-03-20T20:55:27Z

Do you publish from a developer laptop or from CI?

dhruvdutt · 2018-03-20T20:59:15Z

IMO we publish manually. You can see the list of npm publishers here.

ooflorent · 2018-03-20T22:07:57Z

Why not using files field from package.json? It would simplify the maintenance.

evenstensberg · 2018-03-21T07:24:06Z

.npmignore

+
+# Miscellany


Consider revising this

webpack-bot · 2018-03-21T18:01:52Z

@rgbkrk Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ev1stensberg Please review the new changes.

rgbkrk · 2018-03-21T18:05:20Z

Switched this over to using files in the package.json. Note that README.md and certain other files are automatically included and do not have to be explicitly stated in files.

dhruvdutt

LGTM.

rgbkrk · 2018-03-21T18:10:58Z

Just to follow up, even though we're using files now:

Do you publish from a developer laptop or from CI?

IMO we publish manually. You can see the list of npm publishers here.

Since a .npmignore overrides what's in a .gitignore, if a developer has files locally that shouldn't be in the package yet are git ignored, they'll accidentally upload them as part of the package. Some files npm makes sure to avoid .DS_Store, swap files, etc. Since that's a bit of a hairy mess to figure out continuously, the files approach is definitely better.

ematipico

Amazing job! Thanks!!

evenstensberg · 2018-03-22T16:24:46Z

webpack-cli @2.0.13

rgbkrk · 2018-03-22T16:39:04Z

Thanks!

evenstensberg · 2018-04-30T09:00:27Z

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

webpack-bot added PR: unreviewed PR: small labels Mar 15, 2018

rgbkrk mentioned this pull request Mar 15, 2018

Loading arbitrary contents nteract/nteract#2679

Merged

dhruvdutt requested changes Mar 15, 2018

View reviewed changes

webpack-bot added PR: reviewed-changes-requested PR: CI-not-ok and removed PR: unreviewed labels Mar 15, 2018

evenstensberg approved these changes Mar 15, 2018

View reviewed changes

webpack-bot added the PR: reviewed-approved label Mar 15, 2018

evenstensberg reviewed Mar 20, 2018

View reviewed changes

rgbkrk force-pushed the patch-1 branch from c1f45c0 to e06bc04 Compare March 20, 2018 20:00

webpack-bot added PR: review-outdated and removed PR: reviewed-approved PR: reviewed-changes-requested labels Mar 20, 2018

rgbkrk force-pushed the patch-1 branch from 6f8a732 to 9bc6b04 Compare March 20, 2018 20:05

dhruvdutt approved these changes Mar 20, 2018

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels Mar 20, 2018

webpack-bot added PR: review-outdated and removed PR: reviewed-approved labels Mar 20, 2018

dhruvdutt requested changes Mar 20, 2018

View reviewed changes

webpack-bot added the PR: reviewed-changes-requested label Mar 20, 2018

webpack-bot added PR: CI-ok and removed PR: review-outdated PR: CI-not-ok labels Mar 20, 2018

evenstensberg requested changes Mar 21, 2018

View reviewed changes

.npmignore Outdated

# Miscellany

Copy link

Member

evenstensberg Mar 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider revising this

evenstensberg mentioned this pull request Mar 21, 2018

Added .nyc_output to .npmignore #354

Closed

rgbkrk force-pushed the patch-1 branch from 8018bdf to 69f2c5c Compare March 21, 2018 18:01

webpack-bot added PR: review-outdated and removed PR: reviewed-changes-requested labels Mar 21, 2018

chore(pkg): explicitly include files for release

0242c93

rgbkrk force-pushed the patch-1 branch from 69f2c5c to 0242c93 Compare March 21, 2018 18:03

rgbkrk changed the title ~~Don't upload .nyc_output on release~~ chore(pkg): explicitly include files for release Mar 21, 2018

dhruvdutt approved these changes Mar 21, 2018

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels Mar 21, 2018

ematipico approved these changes Mar 22, 2018

View reviewed changes

evenstensberg approved these changes Mar 22, 2018

View reviewed changes

evenstensberg merged commit c3a0c9f into webpack:master Mar 22, 2018

rgbkrk deleted the patch-1 branch March 22, 2018 16:39

bobwalker99 mentioned this pull request Mar 23, 2018

Empty nyc_output file in webpack-cli causes flow failure flow/flow-bin#123

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(pkg): explicitly include files for release #349

chore(pkg): explicitly include files for release #349

rgbkrk commented Mar 15, 2018

jsf-clabot commented Mar 15, 2018 •

edited

Loading

dhruvdutt left a comment

evenstensberg left a comment

rgbkrk commented Mar 15, 2018

dhruvdutt commented Mar 15, 2018

evenstensberg left a comment

rgbkrk commented Mar 20, 2018

dhruvdutt commented Mar 20, 2018

rgbkrk commented Mar 20, 2018

dhruvdutt left a comment

dhruvdutt commented Mar 20, 2018 •

edited

Loading

rgbkrk commented Mar 20, 2018

dhruvdutt left a comment

webpack-bot commented Mar 20, 2018

rgbkrk commented Mar 20, 2018

dhruvdutt commented Mar 20, 2018

ooflorent commented Mar 20, 2018

evenstensberg Mar 21, 2018

webpack-bot commented Mar 21, 2018

rgbkrk commented Mar 21, 2018

dhruvdutt left a comment

rgbkrk commented Mar 21, 2018

ematipico left a comment

evenstensberg commented Mar 22, 2018

rgbkrk commented Mar 22, 2018

evenstensberg commented Apr 30, 2018

chore(pkg): explicitly include files for release #349

chore(pkg): explicitly include files for release #349

Conversation

rgbkrk commented Mar 15, 2018

jsf-clabot commented Mar 15, 2018 • edited Loading

dhruvdutt left a comment

Choose a reason for hiding this comment

evenstensberg left a comment

Choose a reason for hiding this comment

rgbkrk commented Mar 15, 2018

dhruvdutt commented Mar 15, 2018

evenstensberg left a comment

Choose a reason for hiding this comment

rgbkrk commented Mar 20, 2018

dhruvdutt commented Mar 20, 2018

rgbkrk commented Mar 20, 2018

dhruvdutt left a comment

Choose a reason for hiding this comment

dhruvdutt commented Mar 20, 2018 • edited Loading

rgbkrk commented Mar 20, 2018

dhruvdutt left a comment

Choose a reason for hiding this comment

webpack-bot commented Mar 20, 2018

rgbkrk commented Mar 20, 2018

dhruvdutt commented Mar 20, 2018

ooflorent commented Mar 20, 2018

evenstensberg Mar 21, 2018

Choose a reason for hiding this comment

webpack-bot commented Mar 21, 2018

rgbkrk commented Mar 21, 2018

dhruvdutt left a comment

Choose a reason for hiding this comment

rgbkrk commented Mar 21, 2018

ematipico left a comment

Choose a reason for hiding this comment

evenstensberg commented Mar 22, 2018

rgbkrk commented Mar 22, 2018

evenstensberg commented Apr 30, 2018

jsf-clabot commented Mar 15, 2018 •

edited

Loading

dhruvdutt commented Mar 20, 2018 •

edited

Loading