Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add break as commit type and listed the type of commit in the documentation #379

Merged
merged 3 commits into from
Apr 9, 2018
Merged

Add break as commit type and listed the type of commit in the documentation #379

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aed3b9d
chore(dev): added break to the list of type of commit
ematipico Apr 8, 2018
318933f
docs(commits): listed the list of type of commits available
ematipico Apr 8, 2018
c33afd2
docs(commits): alphabetic order
ematipico Apr 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .cz-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ module.exports = {
{ value: "feat", name: "feat: A new feature" },
{ value: "fix", name: "fix: Bugs, typos, etc" },
{ value: "misc", name: "misc: Other formats like tweaks and such" },
{ value: "tests", name: "tests: Tests, jest, binTestCases, etc" }
{ value: "tests", name: "tests: Tests, jest, binTestCases, etc" },
{ value: "break", name: "break: changes that break the behaviour of the cli" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do asc ordering of the new value?

webpack-cli/.cz-config.js

Line 19 in 8a90ea4

// sort type values in asc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's now done

]
};
11 changes: 11 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,17 @@ format that includes a **type** and a **subject**:
<footer>
```

This is the list of *type* of commits that we accept:
* ast
* chore
* cli
* docs
* feat
* fix
* misc
* tests
* break

The **header** is mandatory.

Any line of the commit message cannot be longer 100 characters. This allows the message to be easier
Expand Down