Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use html-loader to default template #4008

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

evenstensberg
Copy link
Member

What kind of change does this PR introduce?
Fixes #3990

Did you add tests for your changes?
No

If relevant, did you update the documentation?
N/A
Summary
Allows images to be loaded in index.html

Does this PR introduce a breaking change?
No
Other information
N/A

@evenstensberg evenstensberg requested a review from a team as a code owner November 16, 2023 21:28
@evenstensberg
Copy link
Member Author

@snitin315 could you update the init snapshots on this PR?

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1de879c) 90.89% compared to head (bd86ed3) 90.89%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4008   +/-   ##
=======================================
  Coverage   90.89%   90.89%           
=======================================
  Files          22       22           
  Lines        1692     1692           
  Branches      488      488           
=======================================
  Hits         1538     1538           
  Misses        154      154           
Files Coverage Δ
packages/generators/src/handlers/default.ts 98.76% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1de879c...bd86ed3. Read the comment docs.

@snitin315
Copy link
Member

I'll update snaps

@alexander-akait
Copy link
Member

@evenstensberg Can you fix CI?

@webpack-bot
Copy link

@evenstensberg Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@alexander-akait Please review the new changes.

@alexander-akait alexander-akait merged commit eea6adf into master Jan 4, 2024
56 checks passed
@alexander-akait alexander-akait deleted the feat/image-loading branch January 4, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With default config, the webpack serve does not serve the images in html
4 participants