Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UglifyJSPlugin transformation #401

Merged
merged 9 commits into from
Apr 18, 2018
Merged

Update UglifyJSPlugin transformation #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
12613d6
cli(migration): Update UglifyJS migration file to fit webpack4 config…
matheus1lva Apr 11, 2018
1bbcc01
cli(migration): Add cases where require variable does not need to exist
matheus1lva Apr 11, 2018
ebb4fa5
cli(migration): Add transformation for usage of webpack.otimization.U…
matheus1lva Apr 11, 2018
8b6522e
cli(tests): Update test snapshots after updating transformation
matheus1lva Apr 11, 2018
74034bf
cli(fix): fix expressionContent being null
matheus1lva Apr 12, 2018
5dded3f
cli(refactor): remove plugins array if empty
matheus1lva Apr 13, 2018
f8c06c8
tests: add tests for new ast-utils method
matheus1lva Apr 13, 2018
c4a05a3
fix: fix test names and jsdoc
matheus1lva Apr 15, 2018
afe9c9a
fix: update maxSize for utils folder
matheus1lva Apr 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 24 additions & 40 deletions lib/migrate/__snapshots__/index.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,40 +61,32 @@ module.exports = {
exports[`transform should respect recast options 1`] = `
"
module.exports = {
devtool: 'eval',

entry: [
devtool: 'eval',
entry: [
'./src/index'
],

output: {
output: {
path: path.join(__dirname, 'dist'),
filename: 'index.js'
},

module: {
module: {
rules: [{
test: /\.js$/,
test: /.js$/,
use: [{
loader: \\"babel-loader\\",
}],
include: path.join(__dirname, 'src')
}]
},

resolve: {
resolve: {
modules: ['node_modules', path.resolve('/src')],
},

plugins: [
new webpack.optimize.UglifyJsPlugin({
sourceMap: true,
}),
new webpack.LoaderOptionsPlugin({
debug: true,
minimize: true,
})
],
plugins: [new webpack.LoaderOptionsPlugin({
debug: true,
})],
optimization: {
minimize: true,
}
};
"
`;
Expand Down Expand Up @@ -135,40 +127,32 @@ module.exports = {
exports[`transform should transform using all transformations 1`] = `
"
module.exports = {
devtool: 'eval',

entry: [
devtool: 'eval',
entry: [
'./src/index'
],

output: {
output: {
path: path.join(__dirname, 'dist'),
filename: 'index.js'
},

module: {
module: {
rules: [{
test: /\.js$/,
test: /.js$/,
use: [{
loader: 'babel-loader'
}],
include: path.join(__dirname, 'src')
}]
},

resolve: {
resolve: {
modules: ['node_modules', path.resolve('/src')]
},

plugins: [
new webpack.optimize.UglifyJsPlugin({
sourceMap: true
}),
new webpack.LoaderOptionsPlugin({
debug: true,
minimize: true
})
]
plugins: [new webpack.LoaderOptionsPlugin({
debug: true
})],
optimization: {
minimize: true
}
};
"
`;
118 changes: 100 additions & 18 deletions lib/migrate/uglifyJsPlugin/__snapshots__/uglifyJsPlugin.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,36 +2,118 @@

exports[`uglifyJsPlugin transforms correctly using "uglifyJsPlugin-0" data 1`] = `
"module.exports = {
plugins: [
new webpack.optimize.UglifyJsPlugin({
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a problem here, something i left behind... i'm fixing it now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

sourceMap: true
})
]
optimization: {
minimize: true
}
}
"
`;

exports[`uglifyJsPlugin transforms correctly using "uglifyJsPlugin-1" data 1`] = `
"module.exports = {
"const UglifyJsPlugin = require('uglifyjs-webpack-plugin');
module.exports = {
devtool: \\"source-map\\",
plugins: [
new webpack.optimize.UglifyJsPlugin({
sourceMap: true
})
]
optimization: {
minimize: true,

minimizer: [new UglifyJsPlugin({
sourceMap: true,
compress: {}
})]
}
}
"
`;

exports[`uglifyJsPlugin transforms correctly using "uglifyJsPlugin-2" data 1`] = `
"const Uglify = require('uglifyjs-webpack-plugin');
module.exports = {
devtool: \\"source-map\\",
optimization: {
minimize: true,

minimizer: [new Uglify({
sourceMap: true,
compress: {}
})]
}
}
"
`;

exports[`uglifyJsPlugin transforms correctly using "uglifyJsPlugin-3" data 1`] = `
"module.exports = {
devtool: \\"cheap-source-map\\",
plugins: [
new webpack.optimize.UglifyJsPlugin({
compress: {},
devtool: 'eval',

entry: [
'./src/index'
],

output: {
path: path.join(__dirname, 'dist'),
filename: 'index.js'
},

module: {
loaders: [{
test: /.js$/,
loaders: ['babel'],
include: path.join(__dirname, 'src')
}]
},

resolve: {
root: path.resolve('/src'),
modules: ['node_modules']
},

plugins: [new webpack.optimize.OccurrenceOrderPlugin()],
debug: true,

optimization: {
minimize: true
}
};
"
`;

exports[`uglifyJsPlugin transforms correctly using "uglifyJsPlugin-4" data 1`] = `
"const UglifyJsPlugin = require('uglifyjs-webpack-plugin');
module.exports = {
devtool: 'eval',

entry: [
'./src/index'
],

output: {
path: path.join(__dirname, 'dist'),
filename: 'index.js'
},

module: {
loaders: [{
test: /.js$/,
loaders: ['babel'],
include: path.join(__dirname, 'src')
}]
},

resolve: {
root: path.resolve('/src'),
modules: ['node_modules']
},

plugins: [new webpack.optimize.OccurrenceOrderPlugin()],
debug: true,

optimization: {
minimize: true,

minimizer: [new UglifyJsPlugin({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? Could you link me to the docs on this?

Copy link
Contributor

@ematipico ematipico Apr 15, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/webpack/webpack/blob/master/test/configCases/plugins/uglifyjs-plugin/webpack.config.js#L20

Yes it is

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oki, good stuff

sourceMap: true
})
]
}
})]
}
};
"
`;
4 changes: 3 additions & 1 deletion lib/migrate/uglifyJsPlugin/__testfixtures__/uglifyJsPlugin-0.input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
const UglifyJsPlugin = require('uglifyjs-webpack-plugin');

module.exports = {
plugins: [
new webpack.optimize.UglifyJsPlugin()
new UglifyJsPlugin()
]
}
6 changes: 5 additions & 1 deletion lib/migrate/uglifyJsPlugin/__testfixtures__/uglifyJsPlugin-1.input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
const UglifyJsPlugin = require('uglifyjs-webpack-plugin');
module.exports = {
devtool: "source-map",
plugins: [
new webpack.optimize.UglifyJsPlugin({})
new UglifyJsPlugin({
sourceMap: true,
compress: {}
})
]
}
6 changes: 4 additions & 2 deletions lib/migrate/uglifyJsPlugin/__testfixtures__/uglifyJsPlugin-2.input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
const Uglify = require('uglifyjs-webpack-plugin');
module.exports = {
devtool: "cheap-source-map",
devtool: "source-map",
plugins: [
new webpack.optimize.UglifyJsPlugin({
new Uglify({
sourceMap: true,
compress: {}
})
]
Expand Down
26 changes: 26 additions & 0 deletions lib/migrate/uglifyJsPlugin/__testfixtures__/uglifyJsPlugin-3.input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
module.exports = {
devtool: 'eval',
entry: [
'./src/index'
],
output: {
path: path.join(__dirname, 'dist'),
filename: 'index.js'
},
module: {
loaders: [{
test: /.js$/,
loaders: ['babel'],
include: path.join(__dirname, 'src')
}]
},
resolve: {
root: path.resolve('/src'),
modules: ['node_modules']
},
plugins: [
new webpack.optimize.UglifyJsPlugin(),
new webpack.optimize.OccurrenceOrderPlugin()
],
debug: true
};
28 changes: 28 additions & 0 deletions lib/migrate/uglifyJsPlugin/__testfixtures__/uglifyJsPlugin-4.input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
module.exports = {
devtool: 'eval',
entry: [
'./src/index'
],
output: {
path: path.join(__dirname, 'dist'),
filename: 'index.js'
},
module: {
loaders: [{
test: /.js$/,
loaders: ['babel'],
include: path.join(__dirname, 'src')
}]
},
resolve: {
root: path.resolve('/src'),
modules: ['node_modules']
},
plugins: [
new webpack.optimize.UglifyJsPlugin({
sourceMap: true
}),
new webpack.optimize.OccurrenceOrderPlugin()
],
debug: true
};
Loading