feat: init create-webpack-app package [1]
#4214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- init create-webpack-app package - installed deps - plop - minimist
added template files which containe handlebar templates and other common files
init .tsconfig
change the internal structure of template files
add build script add watch script
type: module is set in package.json
add ejs for rendering logic using ejs templates in future
for compatibility with plopfile, as it throws error if it's a commonjs file
- change templates to ejs templates - implement ejs rendering logic in plopfile.ts
- remove helper function - remove unnecessary comment
- better input validation - remove entrypoint prompt - fix path issues
- add both index.js and index.ts - fix bud in package.json template file
- fix the url - bumped the required node from 14 -> 18 - removed empty peerDeps and peerMetaDeps fields - fix cli entry point typo
- installs all the packages from deps array to the project directory
- single prompt to ask whether to skip - if yes then returns default answers object - if no then returns the interactive prompts interface
created commander cli implement init command with -s -f flags to skip and -f to override
…date" This reverts commit 838a6fa.
- failure was due to the bypassPrompt of runPrompts from node-plop - so removed bypassPrompt and added manual bypassing in index.ts - also removed prompts for projectPath as presumably they will always be supplied as cli arg
- change delimeter from `:` to `|` in fileActions - normalized paths to ensure compatible stdout
|
@snitin315 Can you rebase and let's merge 👍 |
alexander-akait
previously approved these changes
Oct 14, 2024
|
@alexander-akait Done. |
|
@snitin315 Can we squash them? |
|
@alexander-akait yes, let's squash and merge |
|
@snitin315 Now let's start a new major release:
I think it won't be difficult |
|
@alexander-akait sure, I'll raise PRs for same |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
yes
If relevant, did you update the documentation?
No
Summary
Add a new
create-webpack-apppackage.Does this PR introduce a breaking change?
No
Other information
No