ast(parser): fix bug with literals #499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -432,6 +432,7 @@ function addProperty(j, p, key, value, action) { | |||
| }); | |||
| valForNode = objectExp; | |||
| } else { | |||
| value = `'${value}'`; | |||
There was a problem hiding this comment.
this is incorrect. The reason why your tests are failing on remove is because you haven't double-quoted your strings.
|
Add generator needs to be the one to use double quotes, not ast transform. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix
Did you add tests for your changes?
Yes
Summary
In case of generation of literal nodes, the final string value inside webpack.config.js doesn't yield quotes. This fixes the bug.
Here's a small demo of adding
modebefore and after the fix:Does this PR introduce a breaking change?
No
Other information