Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update jsdoc #507

Merged
merged 1 commit into from
Jun 16, 2018
Merged

docs: update jsdoc #507

merged 1 commit into from
Jun 16, 2018

Conversation

dhruvdutt
Copy link
Member

What kind of change does this PR introduce?

Did you add tests for your changes?

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this will trigger a new release. Should be combined with other commits.

@evenstensberg
Copy link
Member

Swap this to next branch

@evenstensberg evenstensberg changed the base branch from master to next June 15, 2018 11:50
@evenstensberg
Copy link
Member

Would probably be better to open a new PR on this

@dhruvdutt
Copy link
Member Author

I'm getting weird errors like this when I run npm run jsdoc on next branch. It works fine for master branch.

FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory

@ev1stensberg Can you try if it works for you?

@evenstensberg
Copy link
Member

Look up which paths jsdoc is looking for as well as if you have a existing docs folder

@webpack-bot
Copy link

@dhruvdutt Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ev1stensberg Please review the new changes.

Copy link
Member Author

@dhruvdutt dhruvdutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Looks good to merge. 💯

@evenstensberg evenstensberg merged commit 9993ead into webpack:next Jun 16, 2018
dhruvdutt added a commit that referenced this pull request Jun 16, 2018
dhruvdutt added a commit that referenced this pull request Jun 17, 2018
dhruvdutt added a commit that referenced this pull request Jun 21, 2018
evenstensberg pushed a commit that referenced this pull request Jun 24, 2018
dhruvdutt added a commit to dhruvdutt/webpack-cli that referenced this pull request Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants