-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): fix eslint pattern #529
Conversation
package.json
Outdated
@@ -22,7 +22,7 @@ | |||
"bundler" | |||
], | |||
"scripts": { | |||
"lint": "eslint \"./bin/*.js\" \"./test/**/*.js\" \"{packages}/**/!(node_modules)/*.js\" ", | |||
"lint": "eslint \"./bin/*.js\" \"./packages/**/!(node_modules)/*.js\" ", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we ignore the test
folder? It's currently in eslintignore.
Line 3 in cd890a8
test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we don't want to lint the tests? Sounds odd to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. There is no reason to ignore the test. Fixed it.
@@ -1,5 +1,5 @@ | |||
**/__testfixtures__/* | |||
coverage | |||
test | |||
test/binCases/errors/parse/index.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But that's a SyntaxError. It would bomb an error anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. This is error checking test. 😅
webpack-cli/test/binCases/errors/parse/stdin.js
Lines 10 to 13 in cd890a8
expect(stdout[5]).toContain("[failed]"); | |
expect(stdout[5]).toContain("[1 error]"); | |
expect(stdout[7]).toContain("ERROR in ./index.js"); | |
expect(stdout[8]).toContain("Module parse failed:"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification!
!function(e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be ignored from linters, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! So now we have eslint properly set :)
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Other information