Updated working link for webpack addon. #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The link provided in [ webpack-scaffold-yourpackage ] section is missing. I have updated the link, Please verify and accept this PR.
|
|
|
@NaviMarella The most important CI builds failed. This way your PR can't be merged. Please take a look at the CI results from travis (failure) and fix these issues. |
evenstensberg
approved these changes
Jul 12, 2018
dhruvdutt
approved these changes
Jul 12, 2018
|
Hi. The PR looks good, but you will need to update the commit to match the commit format we have. Look at the failing CI and other PRs. That should give you a good enough base for succeeding |
|
I assume CI failed because of the commit message format, Also can you let me know what exactly has gone wrong as CI issues are not clear to understand. |
|
Try using |
|
Thanks for submitting a PR! ❤️ |
dhruvdutt
pushed a commit
that referenced
this pull request
Jul 17, 2018
The link provided in [ webpack-scaffold-yourpackage ] section is missing. I have updated the link, Please verify and accept this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
The link provided in webpack scaffold your package section is missing. I have updated the link, Please verify and accept this PR.
Did you add tests for your changes?
As this is a documentation change, I assume no tests are required.
If relevant, did you update the documentation?
Summary
Trying to help with documentation.
Does this PR introduce a breaking change?
No, it doesn't introduce a breaking change.
Other information
This is my first PR to open-source and i am really excited to contribute to webpack.