-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove appveyor #595
Remove appveyor #595
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm except 1 comment 💙
.cz-config.js
Outdated
@@ -26,6 +26,7 @@ module.exports = { | |||
{ value: "feat", name: "feat: A new feature" }, | |||
{ value: "fix", name: "fix: Bugs, typos, etc" }, | |||
{ value: "misc", name: "misc: Other formats like tweaks and such" }, | |||
{ value: "tests", name: "tests: Tests, jest, binTestCases, etc" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be omitted
@ematipico Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ev1stensberg Please review the new changes. |
@ematipico The most important CI builds failed. This way your PR can't be merged. Please take a look at the CI results from travis (failure) and fix these issues. |
What kind of change does this PR introduce?
CI Change. Part of #590
Did you add tests for your changes?
No
If relevant, did you update the documentation?
Yes
Summary
Removing appveyor from our CIs, as it doesn't help much value to the project
Does this PR introduce a breaking change?
No
Other information
N/A