Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove appveyor #595

Merged
merged 8 commits into from
Sep 18, 2018
Merged

Remove appveyor #595

merged 8 commits into from
Sep 18, 2018

Conversation

ematipico
Copy link
Contributor

What kind of change does this PR introduce?
CI Change. Part of #590

Did you add tests for your changes?
No

If relevant, did you update the documentation?
Yes

Summary
Removing appveyor from our CIs, as it doesn't help much value to the project

Does this PR introduce a breaking change?
No

Other information
N/A

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except 1 comment 💙

.cz-config.js Outdated
@@ -26,6 +26,7 @@ module.exports = {
{ value: "feat", name: "feat: A new feature" },
{ value: "fix", name: "fix: Bugs, typos, etc" },
{ value: "misc", name: "misc: Other formats like tweaks and such" },
{ value: "tests", name: "tests: Tests, jest, binTestCases, etc" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be omitted

@webpack-bot
Copy link

@ematipico Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ev1stensberg Please review the new changes.

@webpack-bot
Copy link

@ematipico The most important CI builds failed. This way your PR can't be merged.

Please take a look at the CI results from travis (failure) and fix these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants