fix: resolve references in schema #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evenstensberg
approved these changes
Sep 22, 2018
webpack-bot
added
PR: reviewed-approved
PR: CI-not-ok
and removed
PR: unreviewed
labels
|
@ematipico any reason for the fix prefix failing? |
sokra
force-pushed
the
bugfix/schema-access
branch
from
a62d1c5 to
b977b23
Compare
|
@sokra Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ev1stensberg Please review the new changes. |
sokra
force-pushed
the
bugfix/schema-access
branch
from
b977b23 to
2bf6732
Compare
bin/config-yargs.js
Outdated
| } | ||
| } | ||
| } | ||
| return schema; |
sokra
force-pushed
the
bugfix/schema-access
branch
from
2bf6732 to
2c06cc0
Compare
Avoid to access definitions directly
sokra
force-pushed
the
bugfix/schema-access
branch
from
2c06cc0 to
a9c9e0d
Compare
Still broken, will fix in another PR. There's some archived package to remove |
|
@ematipico Same CI issue is happening for #602 as well. Seems to be something related to Could be happening because due to removal of |
|
Yes, let's discuss it here #584 PR looks good to me! |
ematipico
approved these changes
Sep 22, 2018
dhruvdutt
approved these changes
Sep 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid accessing definitions directly
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
existing test should be fine
If relevant, did you update the documentation?
not relevant
Summary
refactor the way of accessing webpack's schema to not create a internal dependency on the exact structure of the schema.
Does this PR introduce a breaking change?
No
Other information
see also webpack/webpack#7232