(docs): Make the contributing guide grammar better #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pksjce
approved these changes
Feb 21, 2017
CONTRIBUTING.md
Outdated
| @@ -53,7 +55,7 @@ The [.editorconfig](https://github.com/webpack/webpack-cli/blob/master/.editorco | |||
|
|
|||
| ## Branching Model | |||
|
|
|||
| We based our branching model on [git flow](http://nvie.com/posts/a-successful-git-branching-model/). Instead of working with a `develop` base branch, we use instead the `master` branch. We do it to ease a bit the workflow. However, we find useful adding prefixes to the branches. | |||
| We base our branching model on [git flow](http://nvie.com/posts/a-successful-git-branching-model/). Instead of working with a `develop` base branch, we use the `master` branch instead. We do it to ease the workflow a bit. However, we find that adding prefixes to the branches is useful. | |||
There was a problem hiding this comment.
@pksjce Fixed and squashed :)
karanjthakkar
force-pushed
the
bugix/contributing-guide
branch
from
5f16370 to
2aee6f3
Compare
evenstensberg
pushed a commit
that referenced
this pull request
Feb 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Updates the contributing guide grammar
Did you add tests for your changes?
N/A
If relevant, did you update the documentation?
N/A
Summary
N/A
Does this PR introduce a breaking change?
No.
Other information