chore(deps): pin dependencies #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dhruvdutt The most important CI builds failed. This way your PR can't be merged. Please take a look at the CI results from travis (failure) and fix these issues. |
ematipico
approved these changes
Dec 15, 2018
|
There's a failing test... Does that mean that pinning the dependencies caused a different behaviour of the library? That's odd. We should fix it |
|
It's from uglify/terser test, which PR changed that again? Was recently done |
|
There's an open PR |
|
If it doesnt fail at that then merging that would be nice |
|
Seems like this is a side effect of something. Pinning dependencies wouldn't change anything. |
|
Let’s do this properly Dhruvdut... |
|
Some weird issue. It worked locally for me. Looking into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Dependencies pinning
Did you add tests for your changes?
N/A
If relevant, did you update the documentation?
N/A
Summary
Does this PR introduce a breaking change?
No
Other information
Fixes #697