misc(cli): refactor functions into utils and config dirs, merge yargs… #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… options Moved filed to respective config or utils dir, cleaned up cli.js and removed yargs options and merged in a single file ISSUES CLOSED: webpack#770
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
@evenstensberg fixed conflicts. 😄 |
ematipico
approved these changes
Mar 19, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… options
Moved filed to respective config or utils dir, cleaned up cli.js and removed yargs options and
merged in a single file
ISSUES CLOSED: #770
What kind of change does this PR introduce?
Refactoring of functions to their own directories, merged yargs options and hence cleaned up cli.js
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Auto-deployment of docs is underway #774 will be done soon.
Summary
Does this PR introduce a breaking change?
I didn't encounter while testing any.
Other information
Please suggest if this code structure looks appropriate.