Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(webpack-scaffold): improve prompt and doc #794

Merged
merged 7 commits into from
Mar 19, 2019

Conversation

misterdev
Copy link
Contributor

What kind of change does this PR introduce?
Slight improvement to the webpack-cli init user experience:

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
Yes, also improving formatting and descriptions

Summary
#788

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

INIT.md Outdated Show resolved Hide resolved
INIT.md Outdated Show resolved Hide resolved
INIT.md Outdated Show resolved Hide resolved
@webpack-bot
Copy link

@misterdev Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ematipico Please review the new changes.

@misterdev
Copy link
Contributor Author

Thanks @ematipico!

@misterdev
Copy link
Contributor Author

I've found an incorrect example in packages/webpack-scaffold/README.md that wasn't covered by this PR. I've included it and taken the occasion to also update the Confirm API according to this PR and slightly improving formatting and consistency.

@ematipico
Copy link
Contributor

Amazing contribution! Thank you!

@ematipico ematipico merged commit cdde744 into webpack:master Mar 19, 2019
@misterdev misterdev deleted the enh/scaffold-defaults branch March 19, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants