fix(scaffold): config file is always generated at the project root #801
Conversation
config file is generated at the project root
|
Looking into CI |
|
Also, commit |
Sure thing, on it. 👍 |
add package-lock for utils as new dep was introduced
webpack-bot
added
PR: review-outdated
PR: CI-not-ok
and removed
PR: reviewed-changes-requested
labels
fix ci
There was a problem hiding this comment.
I'd suggest to not add another package. This package basically uses findup-sync, which is already installed in the core cli.
A nice refactoring would be to move this package inside the utility package and expose proper functions to whatever package wants to use it
|
@anshumanv Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
@ematipico this approach looks amazing ✨ Thanks for suggesting this, looks way more maintainable and cleaner. 👍 |
anshumanv
force-pushed
the
config-in-root
branch
from
ad54acb to
9ad3c15
Compare
migrated to use find-up sync to determine project root, removed additional packages
webpack-bot
added
PR: reviewed-changes-requested
and removed
PR: review-outdated
labels
added findup-sync to utils package
webpack-bot
added
PR: reviewed-changes-requested
and removed
PR: review-outdated
labels
do not pass process.cwd()
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
|
@ematipico fixed the issues, can we go ahead with this once builds are green? Will start working on the follow-up PR soon. ✨ |
|
Looks good to go. Nice work. 💯 |
…ebpack#801) * fix(scaffold): config file is always generated at the project root config file is generated at the project root * chore(scaffold): add package-lock for utils add package-lock for utils as new dep was introduced * chore(utils): fix ci fix ci * fix(scaffold): migrated to findup-sync to find the project root migrated to use find-up sync to determine project root, removed additional packages * chore(utils): added findup-sync package to utils package added findup-sync to utils package * chore(scaffold): do not pass process.cwd() do not pass process.cwd()
config file is generated at the project root
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
yes
If relevant, did you update the documentation?
NA
Summary
Determine project root and create the file there.
Does this PR introduce a breaking change?
No
Other information
Ref - #709