chore(types): move to @types/yeoman-generator #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misterdev
commented
Apr 28, 2019
misterdev
changed the title
misterdev
commented
Apr 30, 2019
| ): YeoGenerator { | ||
| return class AddOnGenerator extends Generator { | ||
| public props: InquirerScaffoldObject; | ||
| ): typeof Generator => class AddonGenerator extends Generator { |
There was a problem hiding this comment.
Not sure about typeof Generator, just Generator doesn't work
misterdev
changed the title
misterdev
force-pushed
the
update-yeoman-types
branch
from
7b43d75
to
75a2d7c
Compare
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
ematipico
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Removes custom Yeoman types in favour of
@types/yeoman-generatorSummary
Closes #865
It compiles and seems to be working, I've marked with
// TODOwhere there's some work left to doAny feedback is appreciated :)