-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): add node 12 #872
Conversation
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Seems that bundlesize#295 will be merged soon. |
All good, thanks |
Azure is failing now |
azure-pipelines-template.yml
Outdated
@@ -24,7 +24,7 @@ jobs: | |||
npm -v | |||
displayName: "Print version" | |||
- script: | | |||
npm ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm ci is probably better, runs fresh install with lockfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true, I'm just investigating on what broke the Azure CI :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- "chore(ci): add stable and improve azure config" (6ca6235)(azure)
- "chore(azure): change to npm ci" (8f02bb3)(azure)
Seems that using npm ci
instead of npm install
breaks on "macOS node-6"
It fails with sh: rimraf: command not found
while executing npm run bootstrap
I'm keeping the old npm install
. Any idea on how to fix this is welcome :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better always update npm to latest before use npm commands, npm is very buggy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests: azure tests: azure chore: try to fix symlinks chore: try to fix symlinks chore: remove ci opt chore: remove ci opt chore: remove ci opt chore: remove ci opt chore: remove ci opt chore: remove ci opt chore: remove ci opt chore: remove ci opt chore: :) chore: :) chore: :) chore: :) chore: :) chore: :) chore: :) chore: :D
Hadn't chance to look at CLI for a while now but since last PR i've seen it had gotten so much CI improvements 👏 |
By the way did you try the new WIP PR feature yet @misterdev ? I don't think there is a way to change existing PR into WIP state but for the new ones it's available. |
Hi @EugeneHlushko :) I know about draft pull requests but at the moment Travis doesn't support them :) |
@misterdev Thanks for your update. I labeled the Pull Request so reviewers will review it again. @EugeneHlushko Please review the new changes. |
d1427a5
to
89b307a
Compare
Quick update on this: 1. I can't update npm to the latest version (6.9.0) on every platform:
2. 3. bundlesize#295 has been merged, I'm waiting for the updated package to be published to npm |
We can drop node 6. It's dead now. This would solve half of the issue. |
Everything works now, this is ready to be merged! NB: As suggested by evilebottnawi here, the current azure configuration doesn't update npm to the latest version. The solution proposed doesn't work so I am keeping it unchanged. |
Thank you @misterdev ! |
What kind of change does this PR introduce?
Adds node 12 to Travis and Azure Pipelines and fixes the configuration
Summary
Related to #864
Closes #860