Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add node 12 #872

Merged
merged 14 commits into from
May 22, 2019
Merged

Conversation

misterdev
Copy link
Contributor

@misterdev misterdev commented Apr 29, 2019

What kind of change does this PR introduce?
Adds node 12 to Travis and Azure Pipelines and fixes the configuration

Summary
Related to #864
Closes #860

Seems like iltorb doesn't support node 12
We use bundlesize that depends on iltorb, there's an open PR to fix this bundlesize#295 I guess we should wait for it to be merged.

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@misterdev
Copy link
Contributor Author

misterdev commented May 3, 2019

Seems that bundlesize#295 will be merged soon.
@evilebottnawi, if you want, please take a look at the Azure configuration :) Thanks!

@alexander-akait
Copy link
Member

All good, thanks

@ematipico
Copy link
Contributor

Azure is failing now

@@ -24,7 +24,7 @@ jobs:
npm -v
displayName: "Print version"
- script: |
npm ci
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm ci is probably better, runs fresh install with lockfile

Copy link
Contributor Author

@misterdev misterdev May 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, I'm just investigating on what broke the Azure CI :)

Copy link
Contributor Author

@misterdev misterdev May 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that using npm ci instead of npm install breaks on "macOS node-6"
It fails with sh: rimraf: command not found while executing npm run bootstrap

I'm keeping the old npm install. Any idea on how to fix this is welcome :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better always update npm to latest before use npm commands, npm is very buggy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, on Mac OS it doesn't update npm to the latest version.
But the fix suggested here doesn't work on Linux

I'm going to investigate in the next days :)

misterdev referenced this pull request May 5, 2019
tests: azure

tests: azure

chore: try to fix symlinks

chore: try to fix symlinks

chore: remove ci opt

chore: remove ci opt

chore: remove ci opt

chore: remove ci opt

chore: remove ci opt

chore: remove ci opt

chore: remove ci opt

chore: remove ci opt

chore: :)

chore: :)

chore: :)

chore: :)

chore: :)

chore: :)

chore: :)

chore: :D
@EugeneHlushko
Copy link
Member

Hadn't chance to look at CLI for a while now but since last PR i've seen it had gotten so much CI improvements 👏

@EugeneHlushko
Copy link
Member

By the way did you try the new WIP PR feature yet @misterdev ? I don't think there is a way to change existing PR into WIP state but for the new ones it's available.

@misterdev
Copy link
Contributor Author

Hi @EugeneHlushko :) I know about draft pull requests but at the moment Travis doesn't support them :)

@webpack-bot
Copy link

@misterdev Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@EugeneHlushko Please review the new changes.

@misterdev misterdev force-pushed the add-node12-travis branch 2 times, most recently from d1427a5 to 89b307a Compare May 10, 2019 01:04
@misterdev
Copy link
Contributor Author

misterdev commented May 10, 2019

Quick update on this:

1. I can't update npm to the latest version (6.9.0) on every platform:

  • Currently, we use:

      - task: NodeTool@0
        inputs:
          versionSpec: $(node_version)
        displayName: "Install Node.js"
      - script: |
          npm install -g npm@latest
        displayName: "Install npm"
    

    that doesn't install the latest version on MacOS (89b307a) (azure)

  • The other approach proposed in this comment

     - task: Npm@1
         inputs:
           command: custom
           customCommand: i -g npm@latest
        displayName: 'Install latest NPM'
    

    doesn't work giving an EPERM error on Linux (df4928b)(azure) probably because it needs sudo as suggested here :

    On Microsoft-hosted Linux agents, preface the command with sudo, like sudo npm install -g.

2. npm ci doesn't work on MacOS node 6 (6ca6235)(azure), it may be because of (1)

3. bundlesize#295 has been merged, I'm waiting for the updated package to be published to npm

@ematipico
Copy link
Contributor

We can drop node 6. It's dead now. This would solve half of the issue.

@misterdev misterdev changed the title [WIP] chore(ci): add node 12 chore(ci): add node 12 May 21, 2019
@misterdev
Copy link
Contributor Author

Everything works now, this is ready to be merged!

NB: As suggested by evilebottnawi here, the current azure configuration doesn't update npm to the latest version. The solution proposed doesn't work so I am keeping it unchanged.

@ematipico ematipico merged commit 11554d6 into webpack:master May 22, 2019
@ematipico
Copy link
Contributor

Thank you @misterdev !

@misterdev misterdev deleted the add-node12-travis branch May 22, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ci]: add node@12
6 participants