Fix: Only try to remove deprecated plugins from array expressions

lib/transformations/defineTest.js

@@ -53,7 +53,7 @@ function runTest(dirName, transformName, testFilePrefix) {
 		jscodeshift = jscodeshift.withParser(module.parser);
 	}
 	const ast = jscodeshift(source);
-	const output = transform(jscodeshift, ast).toSource({ quote: 'single' });
+	const output = transform(jscodeshift, ast, source).toSource({ quote: 'single' });
 	expect(output).toMatchSnapshot();
 }
 

lib/transformations/index.js

@@ -37,7 +37,7 @@ function transform(source, transforms, options) {
 		quote: 'single'
 	}, options);
 	transforms = transforms || Object.keys(transformations).map(k => transformations[k]);
-	transforms.forEach(f => f(jscodeshift, ast));
+	transforms.forEach(f => f(jscodeshift, ast, source));
 	return ast.toSource(recastOptions);
 }
 

lib/transformations/removeDeprecatedPlugins/__snapshots__/removeDeprecatedPlugins.test.js.snap

@@ -19,3 +19,14 @@ module.exports = {
 }
 "
 `;
+
+exports[`removeDeprecatedPlugins transforms correctly using "removeDeprecatedPlugins-3" data 1`] = `
+"// This should throw
+export default (config) => {
+    config.plugins.push(new webpack.optimize.UglifyJsPlugin());
+    config.plugins.push(new webpack.optimize.DedupePlugin());
+    config.plugins.push(new webpack.optimize.OccurrenceOrderPlugin());
+    return config
+}
+"
+`;

lib/transformations/removeDeprecatedPlugins/__testfixtures__/removeDeprecatedPlugins-3.input.js

@@ -0,0 +1,7 @@
+// This should throw
+export default (config) => {
+    config.plugins.push(new webpack.optimize.UglifyJsPlugin());
+    config.plugins.push(new webpack.optimize.DedupePlugin());
+    config.plugins.push(new webpack.optimize.OccurrenceOrderPlugin());
+    return config
+}

lib/transformations/removeDeprecatedPlugins/removeDeprecatedPlugins.js

@@ -1,21 +1,48 @@
-const findPluginsByName = require('../utils').findPluginsByName;
+const codeFrame = require('babel-code-frame');
+const chalk = require('chalk');
+const utils = require('../utils');
 
-module.exports = function(j, ast) {
+const example = `plugins: [
+    new webpack.optimize.OccurrenceOrderPlugin(),
+    new webpack.optimize.UglifyJsPlugin(),
+    new webpack.optimize.DedupePlugin()
+]`;
+
+module.exports = function(j, ast, source) {
 	// List of deprecated plugins to remove
 	// each item refers to webpack.optimize.[NAME] construct
 	const deprecatedPlugingsList = [
 		'webpack.optimize.OccurrenceOrderPlugin',
 		'webpack.optimize.DedupePlugin'
 	];
 
-	return findPluginsByName(j, ast, deprecatedPlugingsList)
+	return utils.findPluginsByName(j, ast, deprecatedPlugingsList)
 		.forEach(path => {
-			// Check how many plugins are defined and
-			// if there is only last plugin left remove `plugins: []` completely
-			if (path.parent.value.elements.length === 1) {
-				j(path.parent.parent).remove();
+			// For now we only support the case there plugins are defined in an Array
+			if (path.parent &&
+				path.parent.value &&
+				utils.isType(path.parent.value, 'ArrayExpression')
+			) {
+				// Check how many plugins are defined and
+				// if there is only last plugin left remove `plugins: []` node
+				if (path.parent.value.elements.length === 1) {
+					j(path.parent.parent).remove();
+				} else {
+					j(path).remove();
+				}
 			} else {
-				j(path).remove();
+				const startLoc = path.value.loc.start;
+				console.log(`
+${ chalk.red('Only plugins instantiated in the array can be automatically removed i.e.:') }
+
+${ codeFrame(example, null, null, { highlightCode: true }) }
+
+${ chalk.red('but you use it like this:') }
+
+${ codeFrame(source, startLoc.line, startLoc.column, { highlightCode: true }) }
+
+${ chalk.red('Please remove deprecated plugins manually. ') }
+See ${ chalk.underline('https://webpack.js.org/guides/migrating/')} for more information.`);
 			}
 		});
 };

lib/transformations/removeDeprecatedPlugins/removeDeprecatedPlugins.test.js

@@ -3,3 +3,4 @@ const defineTest = require('../defineTest');
 defineTest(__dirname, 'removeDeprecatedPlugins', 'removeDeprecatedPlugins-0');
 defineTest(__dirname, 'removeDeprecatedPlugins', 'removeDeprecatedPlugins-1');
 defineTest(__dirname, 'removeDeprecatedPlugins', 'removeDeprecatedPlugins-2');
+defineTest(__dirname, 'removeDeprecatedPlugins', 'removeDeprecatedPlugins-3');

package.json

@@ -25,6 +25,7 @@
     "test": "jest --coverage"
   },
   "dependencies": {
+    "babel-code-frame": "^6.22.0",
     "babel-core": "^6.21.0",
     "babel-preset-es2015": "^6.18.0",
     "babel-preset-stage-3": "^6.17.0",