Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lint): fix lint warnings #926

Merged
merged 2 commits into from
Jun 5, 2019
Merged

chore(lint): fix lint warnings #926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c189fc
chore(lint): fix lint warnings
anshumanv Jun 5, 2019
c70920a
chore(generator): rm unused imports
anshumanv Jun 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/generators/init-generator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export default class InitGenerator extends Generator {
}
}

public async prompting() {
public async prompting(): Promise<void | {}> {
const done: () => {} = this.async();
const self: this = this;
let regExpForStyles: string;
Expand Down
2 changes: 0 additions & 2 deletions packages/generators/remove-generator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import * as fs from "fs";
import * as path from "path";
import * as Generator from "yeoman-generator";

Expand Down Expand Up @@ -34,7 +33,6 @@ export default class RemoveGenerator extends Generator {
};
const { configFile } = opts;
let configPath = path.resolve(process.cwd(), configFile);
const webpackConfigExists = fs.existsSync(configPath);
this.webpackOptions = require(configPath);
}

Expand Down
2 changes: 1 addition & 1 deletion packages/migrate/commonsChunkPlugin/commonsChunkPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ export default function(j: JSCodeshift, ast: Node): Node {

// eslint-disable-next-line
cacheGroup[chunkKey] = cacheGroup[chunkKey].map(
(prop): any =>
(prop): string | void =>
prop.key.name === "test"
? mergeTestPropArrowFunction(j, chunkKey, pathValue)
: prop
Expand Down