Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(questions): makes default lang type to none #981

Closed

Conversation

pranshuchittora
Copy link
Member

made default language type in init command to none from es6

What kind of change does this PR introduce?
chore

Did you add tests for your changes?
Nopes

If relevant, did you update the documentation?
Nopes

Summary
In init the default language type is ES6, generally its none (NO), like styling.

Motivation
While working on the init package, I was supposed to run init command multiple numbers of time, hence it was quite tedious to select NO in language type.

Hence, IMO default lang type should be None.

made default language type in init command to nonde from es6
@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Contributor

@misterdev misterdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pranshuchittora, for which reason did you select "NO"? From what I know ES6 is just a superset, so you can just write ES5 if you want :)

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should default to es6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants