Skip to content

Commit

Permalink
feat: remove cjs wrapper
Browse files Browse the repository at this point in the history
  • Loading branch information
alexander-akait committed Dec 16, 2021
1 parent 5bb33a9 commit 3c6c6dc
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 4 deletions.
5 changes: 2 additions & 3 deletions src/utils/setupOutputFileSystem.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
const path = require("path");

const { createFsFromVolume, Volume } = require("memfs");
const memfs = require("memfs");

/** @typedef {import("webpack").MultiCompiler} MultiCompiler */
/** @typedef {import("../index.js").IncomingMessage} IncomingMessage */
Expand Down Expand Up @@ -34,7 +33,7 @@ function setupOutputFileSystem(context) {

outputFileSystem = outputFileSystemFromOptions;
} else {
outputFileSystem = createFsFromVolume(new Volume());
outputFileSystem = memfs.createFsFromVolume(new memfs.Volume());
// TODO: remove when we drop webpack@4 support
// @ts-ignore
outputFileSystem.join = path.join.bind(path);
Expand Down
2 changes: 1 addition & 1 deletion test/helpers/runner.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const express = require("express");
const webpack = require("webpack");
const merge = require("deepmerge");

const middleware = require("../../dist").default;
const middleware = require("../../dist");
const defaultConfig = require("../fixtures/webpack.config");

const configEntries = [];
Expand Down
8 changes: 8 additions & 0 deletions test/utils/setupOutputFileSystem.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ describe("setupOutputFileSystem", () => {
compiler: {},
options: {},
};

setupOutputFileSystem(context);

// make sure that this is the default fs created
expect(context.compiler.outputFileSystem.testFs).toBeTruthy();
expect(context.outputFileSystem.testFs).toBeTruthy();
Expand All @@ -36,7 +38,9 @@ describe("setupOutputFileSystem", () => {
},
options: {},
};

setupOutputFileSystem(context);

context.compiler.compilers.forEach((comp) => {
expect(comp.outputFileSystem).toBeTruthy();
});
Expand All @@ -49,6 +53,7 @@ describe("setupOutputFileSystem", () => {
outputFileSystem: {},
},
};

expect(() => {
setupOutputFileSystem(context);
}).toThrow(/join/);
Expand All @@ -63,6 +68,7 @@ describe("setupOutputFileSystem", () => {
},
},
};

expect(() => {
setupOutputFileSystem(context);
}).toThrow(/mkdirp/);
Expand All @@ -78,7 +84,9 @@ describe("setupOutputFileSystem", () => {
},
},
};

setupOutputFileSystem(context);

expect(context.outputFileSystem).toEqual(context.options.outputFileSystem);
});
});

0 comments on commit 3c6c6dc

Please sign in to comment.