-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for not having to pin strip-ansi #1286
Comments
@TheLarkInn need patch release after merge, otherwise |
See #1279 for a potential solution of running node_modules through Babel. |
I have an issue to add this but for now since it's breaking current
implementations I'd like to see pin and patched.
…On Fri, Jan 19, 2018, 12:24 PM Simon Lydell ***@***.***> wrote:
See #1279 <#1279> for a
potential solution of running node_modules through Babel.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1286 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADQBMBgPv6ouyiFfPv2mPR7TKqMdBQLTks5tMPnhgaJpZM4Rk-d2>
.
|
Broke the entire build |
This is causing issues with our project too. If I try to upgrade to the latest version, I start getting yarn errors:
We're currently on version 2.10.0 and would like to upgrade as the dev server is broken in IE11 in this version. |
This is also breaking our dev build in IE11. Running node_modules through babel is not a solution. Everything in node_modules should already be transpiled. |
Update: Updating from 2.11.0 to 2.11.1 (which uses v3 of strip-ansi) and moving my polyfill for es6-object-assign above the first import in my entry point (not sure if this is related) has fixed my IE11 build.
|
Done for v4 |
Currently we've had to pin @sindresorhus's strip-ansi because of the use of arrow functions. We should essentially make whatever changes needed to allow us to use that code (transpilation etc.) so that it still works for strip-ansi@4+ but without breaking IE 11 compat.
See #1273
The text was updated successfully, but these errors were encountered: