BREAKING CHANGE: remove inline and iframe/live mode #2550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v4 #2550 +/- ##
==========================================
+ Coverage 93.36% 93.43% +0.06%
==========================================
Files 34 34
Lines 1327 1309 -18
Branches 375 369 -6
==========================================
- Hits 1239 1223 -16
+ Misses 85 83 -2
Partials 3 3
Continue to review full report at Codecov.
|
knagaitsev
commented
May 1, 2020
| @@ -3,6 +3,7 @@ | |||
| exports[`Client console.log clientLogLevel is silent 1`] = ` | |||
| Array [ | |||
| "Hey.", | |||
| "[HMR] Waiting for update signal from WDS...", | |||
There was a problem hiding this comment.
This is an issue we should look at separately, clientLogLevel silent is not correctly setting the log level of HMR. We simply were not picking up on it before in this test because it was not inlining HMR before
knagaitsev
changed the title
|
@evilebottnawi @hiroppy Please review. Lots of files had to change because the inline option was so deeply rooted into everything |
hiroppy
approved these changes
May 1, 2020
hiroppy
changed the title
alexander-akait
pushed a commit
that referenced
this pull request
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Removing tests no longer in use
Motivation / Use-Case
Remove inline option, still WIP
Breaking Changes
Yes, removing inline, iframe/live mode
Additional Info