Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): security vulnerability in yargs-parser #2581

Merged
merged 1 commit into from
May 8, 2020
Merged

chore(deps): security vulnerability in yargs-parser #2581

merged 1 commit into from
May 8, 2020

Conversation

Ionaru
Copy link
Contributor

@Ionaru Ionaru commented May 8, 2020

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No.

Motivation / Use-Case

It fixes #2559

Additional info

v4 version of #2566


Running these steps

git checkout v4
npm ci
npm test

Failed on Unable to resolve path to module 'open' import/no-unresolved lint errors.

npm run test:only

Failed on the contentBasePublicPath option › to directory › Request to index and contentBasePublicPath option › to directory › Request to other file tests.

Is there some setup step that I'm missing?

@Ionaru Ionaru marked this pull request as ready for review May 8, 2020 08:52
@hiroppy hiroppy changed the title fix(deps): security vulnerability in yargs-parser chore(deps): security vulnerability in yargs-parser May 8, 2020
@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #2581 into v4 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               v4    #2581   +/-   ##
=======================================
  Coverage   92.84%   92.84%           
=======================================
  Files          35       35           
  Lines        1313     1313           
  Branches      368      368           
=======================================
  Hits         1219     1219           
  Misses         89       89           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 768ced4...4420311. Read the comment docs.

@alexander-akait
Copy link
Member

@Ionaru Thanks, please rebase

@Ionaru
Copy link
Contributor Author

Ionaru commented May 8, 2020

Rebased.

@alexander-akait
Copy link
Member

/cc @hiroppy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants