Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor remove the features option #2604

Merged
merged 1 commit into from
May 14, 2020

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented May 14, 2020

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No need

Motivation / Use-Case

We don't need it, each feature can be enabled/disabled using own options, for example bonjour can be disabled using { bonjour: false } + we have onBeforeSetupMiddleware and onAfterSetupMiddleware options

Also this option is undocumented

Breaking Changes

Yes

Additional Info

No

BREAKING CHANGE: the `features` option was removed
@alexander-akait alexander-akait changed the base branch from master to v4 May 14, 2020 15:16
@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #2604 into v4 will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               v4    #2604   +/-   ##
=======================================
  Coverage   92.36%   92.36%           
=======================================
  Files          35       35           
  Lines        1323     1323           
  Branches      376      375    -1     
=======================================
  Hits         1222     1222           
  Misses         96       96           
  Partials        5        5           
Impacted Files Coverage Δ
lib/Server.js 96.51% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e94238b...2511703. Read the comment docs.

@alexander-akait alexander-akait merged commit 8235fd3 into v4 May 14, 2020
@alexander-akait alexander-akait deleted the refactor-remove-the-features-option branch May 14, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant