Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): remove socket status and log options.dev.publicPath only if specified #2849

Merged
merged 3 commits into from
Nov 20, 2020

Conversation

ylemkimon
Copy link
Contributor

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

N/A

Motivation / Use-Case

Breaking Changes

N/A

Additional Info

@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #2849 (a6cb2dd) into v4 (e647af4) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v4    #2849      +/-   ##
==========================================
- Coverage   93.02%   93.02%   -0.01%     
==========================================
  Files          39       39              
  Lines        1305     1304       -1     
  Branches      355      355              
==========================================
- Hits         1214     1213       -1     
  Misses         87       87              
  Partials        4        4              
Impacted Files Coverage Δ
lib/utils/status.js 88.23% <100.00%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e647af4...a6cb2dd. Read the comment docs.

@alexander-akait alexander-akait merged commit 1aa0d2d into webpack:v4 Nov 20, 2020
@alexander-akait
Copy link
Member

Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants