Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use location.port as the client port by default #2850

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

ylemkimon
Copy link
Contributor

@ylemkimon ylemkimon commented Nov 20, 2020

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Modified existing tests.

Motivation / Use-Case

#2845 (comment)

Breaking Changes

Yes, the client uses the port of the current location (location.port, equivalent to sockPort: 'location'), by default. To get existing behavior, set the client.port with the port you'd like to set to, e.g.:

const server = new Server(compiler, {
  client: {
    port,
  }
});
server.listen(port, hostname);

Additional Info

@ylemkimon ylemkimon mentioned this pull request Nov 20, 2020
6 tasks
@ylemkimon ylemkimon changed the title fix: use location.port as sock.port by default fix: use location.port as the socket port by default Nov 20, 2020
@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #2850 (1c3bc85) into v4 (1aa0d2d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v4    #2850      +/-   ##
==========================================
- Coverage   93.02%   93.01%   -0.02%     
==========================================
  Files          39       39              
  Lines        1304     1302       -2     
  Branches      355      355              
==========================================
- Hits         1213     1211       -2     
  Misses         87       87              
  Partials        4        4              
Impacted Files Coverage Δ
lib/utils/DevServerPlugin.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aa0d2d...1c3bc85. Read the comment docs.

@ylemkimon ylemkimon changed the title fix: use location.port as the socket port by default fix: use location.port as the client port by default Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants