Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename client properties #3169

Closed
wants to merge 1 commit into from
Closed

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes updated existing ones

Motivation / Use-Case

following changes for client option -

host to webSocketHost
port to webSocketPort
path to webSocketPath

Breaking Changes

client.host, client.port, client.path were removed.

Additional Info

None

`host` to `webSocketHost`
`port` to `webSocketPort`
`path` to `webSocketPath`
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should union these options and remove the public in favor socketURL, example usage:

client: {
  socketURL: 'ws://hostname:port/path'
}

If you need provide only some of them developer can use ws://0.0.0.0:0/path.

0.0.0.0 means pick self.location.hostname
:0 means pick self.location.port

I already do some implements here #3159 for this refactor

@alexander-akait
Copy link
Member

If you help me with this will be great, I think it is one of the last braking change and we will do rc

@snitin315
Copy link
Member Author

Let's do it 🚀

@anshumanv
Copy link
Member

Stale, closing in favour of #3309

@anshumanv anshumanv closed this May 23, 2021
@alexander-akait alexander-akait deleted the refactor-client-props branch May 24, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants