Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect infastructureLogging.level for client.logging #3613

Merged
merged 7 commits into from
Aug 16, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

yes

Motivation / Use-Case

Fix #2889

Breaking Changes

None

Additional Info

No


options.client.logging =
configWithInfrastructureLogging.infrastructureLogging.level;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need better logic here, ideally we should get options from compiler where we found devServer options

@alexander-akait alexander-akait marked this pull request as ready for review August 15, 2021 19:11
@alexander-akait
Copy link
Member

WIP on tests

@alexander-akait
Copy link
Member

Also refactor other weird cases

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #3613 (6094d7a) into master (f67179c) will decrease coverage by 0.29%.
The diff coverage is 91.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3613      +/-   ##
==========================================
- Coverage   93.87%   93.58%   -0.30%     
==========================================
  Files          15       15              
  Lines        1290     1294       +4     
  Branches      443      446       +3     
==========================================
  Hits         1211     1211              
- Misses         72       76       +4     
  Partials        7        7              
Impacted Files Coverage Δ
lib/Server.js 93.42% <91.89%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f67179c...6094d7a. Read the comment docs.

@alexander-akait alexander-akait merged commit c9ccc96 into master Aug 16, 2021
@alexander-akait alexander-akait deleted the respect-infrastructure-logging branch August 16, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants