Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proxy logging and allow to pass options without the target option #3651

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Aug 16, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

fixes #3486 fixes #3647

Motivation / Use-Case

fixes

Breaking Changes

No

Additional Info

TODO for the next major release

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #3651 (d63405f) into master (c9ccc96) will increase coverage by 0.10%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3651      +/-   ##
==========================================
+ Coverage   93.58%   93.69%   +0.10%     
==========================================
  Files          15       15              
  Lines        1294     1300       +6     
  Branches      446      449       +3     
==========================================
+ Hits         1211     1218       +7     
+ Misses         76       75       -1     
  Partials        7        7              
Impacted Files Coverage Δ
lib/Server.js 93.58% <87.50%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9ccc96...d63405f. Read the comment docs.

@alexander-akait alexander-akait merged commit 6e2cbde into master Aug 16, 2021
@alexander-akait alexander-akait deleted the fix-proxy-logging-and-accept-options-with-the-router-option branch August 16, 2021 14:49
@alexander-akait
Copy link
Member Author

I will fix random tests fail late

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proxy without target
2 participants