Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update ws #3652

Merged
merged 9 commits into from
Aug 17, 2021
Merged

chore(deps): update ws #3652

merged 9 commits into from
Aug 17, 2021

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

exiting

Motivation / Use-Case

update ws to the latest version

Breaking Changes

Should be no

Additional Info

no

@alexander-akait
Copy link
Member Author

Somewhere in our tests we don't close server... freeze on CI 😫

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #3652 (6424d4f) into master (f94b84f) will decrease coverage by 0.02%.
The diff coverage is 91.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3652      +/-   ##
==========================================
- Coverage   93.69%   93.66%   -0.03%     
==========================================
  Files          15       15              
  Lines        1300     1311      +11     
  Branches      449      452       +3     
==========================================
+ Hits         1218     1228      +10     
- Misses         75       76       +1     
  Partials        7        7              
Impacted Files Coverage Δ
lib/Server.js 93.64% <89.47%> (+0.05%) ⬆️
lib/servers/SockJSServer.js 97.36% <100.00%> (+0.07%) ⬆️
lib/servers/WebsocketServer.js 92.10% <100.00%> (+0.43%) ⬆️
lib/utils/DevServerPlugin.js 98.55% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f94b84f...6424d4f. Read the comment docs.

@alexander-akait alexander-akait merged commit 493ccbd into master Aug 17, 2021
@alexander-akait alexander-akait deleted the update-ws branch August 17, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant