test: add e2e test for universal compiler #3656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
requested review from
alexander-akait,
anshumanv,
hiroppy and
knagaitsev
as code owners
test/e2e/universal-compiler.test.js
Outdated
| // but we'll do it here to check the contents | ||
| const compiler = webpack(config); | ||
| const devServerOptions = { | ||
| host: "127.0.0.1", |
There was a problem hiding this comment.
Let's avoid using host, it is unnecessary (same for other test)
Codecov Report
@@ Coverage Diff @@
## master #3656 +/- ##
=======================================
Coverage 93.69% 93.69%
=======================================
Files 15 15
Lines 1300 1300
Branches 449 449
=======================================
Hits 1218 1218
Misses 75 75
Partials 7 7 Continue to review full report at Codecov.
|
snitin315
force-pushed
the
e2e-universal-compiler
branch
from
4972bd1
to
264ced1
Compare
anshumanv
approved these changes
Aug 17, 2021
|
Looks like a random macOs faliure, can we ignore it? |
|
Yep, I will improve our test for more stable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
It is test
Motivation / Use-Case
migrate universal compiler test to e2e testing.
Breaking Changes
none
Additional Info
No