Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove killable #3657

Merged
merged 4 commits into from
Aug 17, 2021
Merged

refactor: remove killable #3657

merged 4 commits into from
Aug 17, 2021

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No

Motivation / Use-Case

less deps

Breaking Changes

No

Additional Info

No

lib/Server.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #3657 (6f43ab6) into master (75bafbf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3657   +/-   ##
=======================================
  Coverage   93.66%   93.67%           
=======================================
  Files          15       15           
  Lines        1311     1312    +1     
  Branches      452      450    -2     
=======================================
+ Hits         1228     1229    +1     
  Misses         76       76           
  Partials        7        7           
Impacted Files Coverage Δ
lib/Server.js 93.69% <100.00%> (+0.05%) ⬆️
lib/servers/BaseServer.js 100.00% <100.00%> (ø)
lib/servers/SockJSServer.js 97.14% <100.00%> (-0.23%) ⬇️
lib/servers/WebsocketServer.js 91.42% <100.00%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75bafbf...6f43ab6. Read the comment docs.

@snitin315 snitin315 changed the title refactor: remove killable in favor of mehtod refactor: remove killable Aug 17, 2021
lib/Server.js Outdated Show resolved Hide resolved
lib/Server.js Outdated Show resolved Hide resolved
@snitin315 snitin315 force-pushed the rm-killable branch 2 times, most recently from f0acead to aea1b09 Compare August 17, 2021 13:09
@alexander-akait alexander-akait merged commit 22b1414 into master Aug 17, 2021
@alexander-akait alexander-akait deleted the rm-killable branch August 17, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants