Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds options.headers being set on any request to files within the content base #70

Merged
merged 1 commit into from
Dec 15, 2014
Merged

Adds options.headers being set on any request to files within the content base #70

merged 1 commit into from
Dec 15, 2014

Conversation

tdeekens
Copy link
Contributor

Adds support for specifying options.headers which are then set on any request to a file within the content base not just the bundles. The pull requests relates to issue #69.

A webpack.config.js such as

...
devServer: {
   headers: { "Access-Control-Allow-Origin": "*" }
}
...

would set the Access-Control-Allow-Origin entry on e.g. the index.html within the content base.

@tdeekens
Copy link
Contributor Author

Any news on merging this in, any changes which have to be made or is it just not of interest?

sokra added a commit that referenced this pull request Dec 15, 2014
Adds options.headers being set on any request to files within the content base
@sokra sokra merged commit cf46798 into webpack:master Dec 15, 2014
@sokra
Copy link
Member

sokra commented Dec 15, 2014

Thanks

@sokra
Copy link
Member

sokra commented Dec 15, 2014

Sorry I forgot it... Too many issues...

@tdeekens
Copy link
Contributor Author

No worries, cheers for merging it in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants