-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Plugin) API Rewrite #1754
(Plugin) API Rewrite #1754
Conversation
@TheLarkInn @sokra I could really use some help with finishing the documentation on this branch soon (mostly just need to know the missing hook descriptions). I also think we need to update the following utility READMEs as such:
|
So you mean this would be for authors looking to write their own hooks for their own plugin systems etc? @mlcohen could definitely help here. |
That too, but also for webpack plugin authors who just want to know how the
...for each would be great. I know they may seem obvious to people who are very familiar with I can move some of this to an issue in the |
This moves some of the content from `compiler.md` and brings it into the main node api documentation in order to allow `compiler.md` to become `compiler-hooks.md` which fits better in the context of plugins.
…le.md` This moves some of the `Tapable` discussion to the lead-in `plugins.md` to prevent doc duplication. Instead of redocumenting the `tapable` package, we should focus on improving the README and simply link to there throughout our docs. As I've mentioned before, we can also create a "Utilities" section for things other than "Loaders" and "Plugins" that we want to dynamically pull in.
These guides were full of todos and probably lead to more confusion than clarity. We can discuss more and add them back in once there's a clear flow for how to incorporate and document them.
This page now focuses specifically on the `hooks` as all the non-plugin related content was moved to `node.md`. I updated the hooks to the new syntax, added all undocumented hooks, reformatted each hook as a section to allow more breathing room, and clarified exactly which `tapable` hook is used for each section. Still need to get more info on some of the new hooks before we can ship this...
This page now uses the same section setup as `compiler-hooks.md` and is up to date with the latest hooks available in the webpack 4 alpha release.
98c1dd3
to
40a6df0
Compare
Improve lead-in to give a little more context on what the parser does. Add the latest hooks and use the same layout as the other pages in the section.
@TheLarkInn merging before this gets too far behind. I highly recommend that either you, @sokra, or someone else who is familiar with the webpack v4 hooks go through the following pages and fill out the hook descriptions:
I standardized the format of each hook section and I think I got all new/renamed hooks added. I didn't feel qualified enough to fill in the descriptions for the rest (i.e. every one with |
This point of this pr is to:
tapable
docs.Resolves #1505
Resolves #1458
Resolves #940
This also begins the process of resolving #1706. Notice that I've targeted this to a
next
branch where we can begin mergingv4
related PRs. Once webpack v4 is fully released (around february it sounds like) we can...3.10.x
) to make it easy to archive and make available later on.next
to make sure it's fully up to date with anything onmaster
.next
branch to master and continue improving the docs.