Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(devServer): add sockPath docs #2791

Merged
merged 6 commits into from
Mar 25, 2019

Conversation

trescenzi
Copy link
Contributor

Related PR

This adds documentation for the sockPath option added by the related PR above.

@montogeek
Copy link
Member

This change is already released?

@trescenzi
Copy link
Contributor Author

@montogeek that's a good question. It's been merged but I don't know the release cycle of webpack-dev-server. According to the releases page the answer is, currently, no.

@evilebottnawi what is the release strategy of webpack-dev-server and when might sockPath get released?

@alexander-akait
Copy link
Member

@trescenzi in near future

Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case we cannot merge this in, please ping us on this PR again when its merged

@arusahni
Copy link

Hi, this appears to be in 3.2.1.

src/content/configuration/dev-server.md Outdated Show resolved Hide resolved
src/content/configuration/dev-server.md Outdated Show resolved Hide resolved
@EugeneHlushko
Copy link
Member

@trescenzi are you still around to apply suggestion?

EugeneHlushko and others added 2 commits March 25, 2019 12:17
Co-Authored-By: trescenzi <trescenzi@gmail.com>
Co-Authored-By: trescenzi <trescenzi@gmail.com>
@trescenzi
Copy link
Contributor Author

@EugeneHlushko let me know if there's anything else I should change.

@EugeneHlushko EugeneHlushko merged commit 7ffe2a5 into webpack:master Mar 25, 2019
@EugeneHlushko
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants