-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(plugins): add ChunksWebpackPlugin #3771
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/dae87rdvm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great addition, although it requires some changes, you can applu the suggested changes and clarify the questions or if suggestions dont look good we can discuss them individually
var to const Co-authored-by: Eugene Hlushko <jhlushko@gmail.com>
var to const Co-authored-by: Eugene Hlushko <jhlushko@gmail.com>
Update doc Co-authored-by: Eugene Hlushko <jhlushko@gmail.com>
var to const Co-authored-by: Eugene Hlushko <jhlushko@gmail.com>
var to const Co-authored-by: Eugene Hlushko <jhlushko@gmail.com>
Update doc Co-authored-by: Eugene Hlushko <jhlushko@gmail.com>
Update doc Co-authored-by: Eugene Hlushko <jhlushko@gmail.com>
Update doc Co-authored-by: Eugene Hlushko <jhlushko@gmail.com>
Co-authored-by: Eugene Hlushko <jhlushko@gmail.com>
Co-authored-by: Eugene Hlushko <jhlushko@gmail.com>
Co-authored-by: Eugene Hlushko <jhlushko@gmail.com>
Thank you @EugeneHlushko for your comments 👍. I have a few questions about open threads. |
Co-authored-by: Eugene Hlushko <jhlushko@gmail.com>
Co-authored-by: James George <jamesgeorge998001@gmail.com>
Co-authored-by: Eugene Hlushko <jhlushko@gmail.com>
Thanks @EugeneHlushko and @jamesgeorge007, everything is up to date. |
Co-authored-by: Fernando Montoya <montogeek@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all looks good i just spotted last minor corrections, if we will merge them in and see if CI still passes then merge it into master
Co-authored-by: Eugene Hlushko <jhlushko@gmail.com>
I think we don't merge it, better to put it here https://github.com/webpack/webpack.js.org/blob/master/repositories/plugins.json and imporve original README of the plugin, it is not official plugin and can be removed/broken/vulnerable in any time without support from the official team |
@EugeneHlushko Any ideas why the CI job Lint and Build fails for the last commit? It is only minor text corrections and I don't understand the error report. |
Why we should not merge it and put it in list of plugins:
We should avoid adding pages for non official plugins, only include them https://github.com/webpack/webpack.js.org/blob/master/repositories/plugins.json Also we should highlight official plugins, and show vendor plugins as nonofficial, I get very often issues in webpack/webpack-contrib orgs related to non official loaders/plugins, developers think that they see it in the official documentation, we should help them with any problems, but we can't do it, so we should solve this problem I can open an issue about it and we will continue discussion there /cc @EugeneHlushko |
@yoriiis I am not against your plugin in docs, I just want to reconsider our approach to documentation for loaders/plugins |
@evilebottnawi I understand, although I think it could help webpack users. For compatibility with webpack 5, I think there are other plugins not yet compatible right? For the differences in the README files, we have made several changes with the help of @EugeneHlushko to improve the documentation, thanks for that. I will update all of these changes in the original README file, for sure. If I can help you in the official team, it's with pleasure. |
This PR adds the
ChunksWebpackPlugin
to the plugins documentation page.A dedicated page with instructions for use is also added.