feat: new CLI documentation #4051

anshumanv · 2020-10-09T04:15:18Z

Documentation for new CLI

Read and sign the CLA. PRs that haven't signed it won't be accepted.
Make sure your PR complies with the writer's guide.
Review the diff carefully as sometimes this can reveal issues.
Do not abandon your Pull Request: Stale Pull Requests.

/cc @webpack/cli-team would be great if you can start reviewing ⭐

vercel · 2020-10-09T04:15:24Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/k2pojpqtt
✅ Preview: https://webpack-js-org-git-cli-docs.webpack-docs.vercel.app

snitin315

Looks Good. Added a few comments.

I think we need to add this link somewhere as appropriate -> https://github.com/webpack/webpack-cli/tree/next/packages/webpack-cli#supported-arguments-and-commands

src/content/api/cli.md

alexander-akait

Can we give link here on full list of options (webpack@5)?

rishabh3112

Nice start.
Left some more suggestions, also few flags are not here from webpack 5, we need too add them some how.

src/content/api/cli.md

snitin315 · 2020-10-10T10:33:22Z

Great work @anshumanv 🎉

alexander-akait · 2020-10-10T12:34:53Z

@anshumanv Can you rebase?

anshumanv · 2020-10-10T13:42:43Z

Done @evilebottnawi

anshumanv · 2020-10-10T17:49:56Z

@webpack/cli-team all good?

jamesgeorge007

Left a suggestion.

src/content/api/cli.md

snitin315 · 2020-10-11T02:41:37Z

@webpack/cli-team all good?

#4051 (comment)

src/content/api/cli.md

alexander-akait

Big thanks!

anshumanv · 2020-10-14T12:08:30Z

@EugeneHlushko @montogeek can you folks also review? We're getting a bunch of issues about stale docs.

/cc @evilebottnawi

src/content/api/cli.md

sokra · 2020-10-14T12:24:07Z

I merge it so we have at least some content, but the page probably need an improvement afterwards, e. g. output stats are outdated (webpack 4)

anshumanv · 2020-10-14T12:31:05Z

I merge it so we have at least some content, but the page probably need an improvement afterwards, e. g. output stats are outdated (webpack 4)

Updated the output stats, we'll still need little updates after some ongoing enhancements though but this should at least give users some understanding about the current behaviour.

anshumanv · 2020-10-14T12:51:51Z

API rate limit on Travis

sokra · 2020-10-14T12:53:34Z

Thanks

lgodziejewski · 2021-01-28T19:36:03Z

@anshumanv thanks for the changes!

I think they should also be ported to the webpack-4 branch (if that's the one v4 docs are built from 😛), as currently the v4 docs are outdated

anshumanv · 2021-01-29T06:02:19Z

Yes that's correct @lgodziejewski, will PR to v4 branch in a while

vercel bot deployed to Preview October 9, 2020 04:15 View deployment

snitin315 reviewed Oct 9, 2020

View reviewed changes

src/content/api/cli.md Show resolved Hide resolved

src/content/api/cli.md Show resolved Hide resolved

src/content/api/cli.md Show resolved Hide resolved

src/content/api/cli.md Outdated Show resolved Hide resolved

src/content/api/cli.md Outdated Show resolved Hide resolved

alexander-akait reviewed Oct 9, 2020

View reviewed changes

rishabh3112 suggested changes Oct 9, 2020

View reviewed changes

src/content/api/cli.md Outdated Show resolved Hide resolved

src/content/api/cli.md Outdated Show resolved Hide resolved

src/content/api/cli.md Outdated Show resolved Hide resolved

src/content/api/cli.md Show resolved Hide resolved

src/content/api/cli.md Outdated Show resolved Hide resolved

jamesgeorge007 reviewed Oct 9, 2020

View reviewed changes

src/content/api/cli.md Outdated Show resolved Hide resolved

vercel bot deployed to Preview October 10, 2020 06:15 View deployment

rishabh3112 reviewed Oct 10, 2020

View reviewed changes

src/content/api/cli.md Outdated Show resolved Hide resolved

vercel bot deployed to Preview October 10, 2020 06:56 View deployment

anshumanv changed the title ~~feat[wip]: new CLI documentation~~ feat: new CLI documentation Oct 10, 2020

vercel bot deployed to Preview October 10, 2020 07:26 View deployment

snitin315 reviewed Oct 10, 2020

View reviewed changes

src/content/api/cli.md Outdated Show resolved Hide resolved

vercel bot deployed to Preview October 10, 2020 11:05 View deployment

anshumanv added 6 commits October 10, 2020 19:05

feat: new CLI documentation

a534251

fix cli docs

d07c063

fix cli docs

b9e2fdb

fix cli docs

39b1006

fix cli docs

a43bcc2

fix: chore cli docs

94c437e

anshumanv force-pushed the cli-docs branch from f7583e6 to 94c437e Compare October 10, 2020 13:42

vercel bot deployed to Preview October 10, 2020 13:42 View deployment

snitin315 mentioned this pull request Oct 10, 2020

v4 does not print when the compilation starts and ends in watch mode webpack/webpack-cli#1902

Closed

jamesgeorge007 suggested changes Oct 10, 2020

View reviewed changes

jamesgeorge007 reviewed Oct 10, 2020

View reviewed changes

src/content/api/cli.md Outdated Show resolved Hide resolved

vercel bot deployed to Preview October 10, 2020 18:30 View deployment

fix: cli docs

df5a50d

vercel bot deployed to Preview October 11, 2020 17:43 View deployment

fix: cli docs

4f64ba2

vercel bot deployed to Preview October 11, 2020 17:56 View deployment

anshumanv requested a review from alexander-akait October 12, 2020 13:08

snitin315 approved these changes Oct 13, 2020

View reviewed changes

alexander-akait reviewed Oct 13, 2020

View reviewed changes

src/content/api/cli.md Outdated Show resolved Hide resolved

alexander-akait reviewed Oct 13, 2020

View reviewed changes

src/content/api/cli.md Show resolved Hide resolved

chore: fix cli docs

716696c

anshumanv requested a review from alexander-akait October 13, 2020 12:08

vercel bot deployed to Preview October 13, 2020 12:08 View deployment

alexander-akait approved these changes Oct 13, 2020

View reviewed changes

anshumanv mentioned this pull request Oct 14, 2020

feat: allow passing strings in env flag webpack/webpack-cli#1939

Merged

sokra requested changes Oct 14, 2020

View reviewed changes

src/content/api/cli.md Outdated Show resolved Hide resolved

src/content/api/cli.md Outdated Show resolved Hide resolved

src/content/api/cli.md Outdated Show resolved Hide resolved

src/content/api/cli.md Show resolved Hide resolved

nitpicks

f30b0de

vercel bot deployed to Preview October 14, 2020 12:20 View deployment

chore: fix cli docs

d60a35e

vercel bot deployed to Preview October 14, 2020 12:28 View deployment

anshumanv requested a review from sokra October 14, 2020 12:33

sokra merged commit c5aa30e into webpack:master Oct 14, 2020

anshumanv deleted the cli-docs branch October 14, 2020 12:54

montogeek added the API label Oct 14, 2020

chenxsan mentioned this pull request Jul 3, 2022

Update migration v4 to v5 guide to include env variable changes #6064

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: new CLI documentation #4051

feat: new CLI documentation #4051

anshumanv commented Oct 9, 2020 •

edited

Loading

vercel bot commented Oct 9, 2020 •

edited

Loading

snitin315 left a comment

alexander-akait left a comment

rishabh3112 left a comment

snitin315 commented Oct 10, 2020

alexander-akait commented Oct 10, 2020

anshumanv commented Oct 10, 2020

anshumanv commented Oct 10, 2020

jamesgeorge007 left a comment

snitin315 commented Oct 11, 2020

alexander-akait left a comment

anshumanv commented Oct 14, 2020

sokra commented Oct 14, 2020 •

edited

Loading

anshumanv commented Oct 14, 2020

anshumanv commented Oct 14, 2020

sokra commented Oct 14, 2020

lgodziejewski commented Jan 28, 2021 •

edited

Loading

anshumanv commented Jan 29, 2021

feat: new CLI documentation #4051

feat: new CLI documentation #4051

Conversation

anshumanv commented Oct 9, 2020 • edited Loading

vercel bot commented Oct 9, 2020 • edited Loading

snitin315 left a comment

Choose a reason for hiding this comment

alexander-akait left a comment

Choose a reason for hiding this comment

rishabh3112 left a comment

Choose a reason for hiding this comment

snitin315 commented Oct 10, 2020

alexander-akait commented Oct 10, 2020

anshumanv commented Oct 10, 2020

anshumanv commented Oct 10, 2020

jamesgeorge007 left a comment

Choose a reason for hiding this comment

snitin315 commented Oct 11, 2020

alexander-akait left a comment

Choose a reason for hiding this comment

anshumanv commented Oct 14, 2020

sokra commented Oct 14, 2020 • edited Loading

anshumanv commented Oct 14, 2020

anshumanv commented Oct 14, 2020

sokra commented Oct 14, 2020

lgodziejewski commented Jan 28, 2021 • edited Loading

anshumanv commented Jan 29, 2021

anshumanv commented Oct 9, 2020 •

edited

Loading

vercel bot commented Oct 9, 2020 •

edited

Loading

sokra commented Oct 14, 2020 •

edited

Loading

lgodziejewski commented Jan 28, 2021 •

edited

Loading