Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/loaders: add index of important loaders #804

Merged
merged 2 commits into from
Feb 5, 2017
Merged

Conversation

simon04
Copy link
Collaborator

@simon04 simon04 commented Feb 3, 2017

@bebraw
Copy link
Contributor

bebraw commented Feb 4, 2017

I wonder what to do with those license links. I guess we should resolve them to the packages somehow as now it's trying to look up against the site itself.

@simon04
Copy link
Collaborator Author

simon04 commented Feb 4, 2017

The idea of those license links/checks is to make sure that the included content is under a compatible license?

@bebraw
Copy link
Contributor

bebraw commented Feb 4, 2017

The links are broken in npm too due to the way they have been written. I guess the best fix would be to fix the links at each package for this reason rather than work around here.

@simon04
Copy link
Collaborator Author

simon04 commented Feb 4, 2017

Hopefully those PRs will be merged quickly 😄

@bebraw
Copy link
Contributor

bebraw commented Feb 5, 2017

@simon04 Merged the PRs.

@simon04
Copy link
Collaborator Author

simon04 commented Feb 5, 2017

Thank you! Now the Travis build succeeds.

@bebraw bebraw merged commit d06d031 into webpack:master Feb 5, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants