assign correct records and cache to child compilations #4704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sokra
added a commit
to webpack-contrib/extract-text-webpack-plugin
that referenced
this pull request
Apr 13, 2017
This is recommended after webpack/webpack#4704
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Closed
This is a breaking change because plugins or loader could rely on this incorrect behavior When using child compilations plugins and loaders should use a unique compiler name or use a consistent order fixes #2777
sokra
force-pushed
the
bugfix/child-records-cache
branch
from
7a50c0f
to
101850c
Compare
|
When will this be merged? It looks like webpack-contrib/extract-text-webpack-plugin#389 will be fixed afterward. (I don't mean to rush anybody, I just want to know whether I should wait for this to happen soon) |
|
It will be merged into the next major version. |
joshwiens
pushed a commit
to webpack-contrib/extract-text-webpack-plugin
that referenced
this pull request
Jun 11, 2017
This is recommended after webpack/webpack#4704
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
no
If relevant, link to documentation update:
N/A
Summary
fixes #2777
creating a child compiler now assigns correct cache and records
compiler name is made relative
Does this PR introduce a breaking change?
yes
This is a breaking change because plugins or loader could rely on this incorrect behavior
Other information
When using child compilations plugins and loaders should use a unique compiler name or use a consistent order