Added continents #43
Open
Added continents #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Is it cleaner that you insert the continent with a relation. to avoid data duplication? |
|
Could you update your PR so it can merge again, since it has conflicts now? |
|
@webpatser Will do as soon as I have some time on my hands. There are some changes in the countries.json file so I'll need some time to review the merge by hand. |
# Conflicts: # src/Webpatser/Countries/Models/countries.json
Add currency decimals and json changes in order to make a merge
Fix countries JSON for base branch merger
|
@webpatser PR updated |
|
With the changes for Laravel 5.5 support, your PR is conflicting. Can review your changes again. Then we can merge your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added continents to countries.
Source is https://restcountries.eu/