No point in adding unignores to fast-glob options

webpro-nl · Sep 7, 2024 · 859403b · 859403b
1 parent b583ae8
commit 859403b
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/packages/knip/src/util/glob-core.ts b/packages/knip/src/util/glob-core.ts
@@ -199,8 +199,8 @@ export async function globby(patterns: string | string[], options: GlobOptions):
     while (dir) {
       const cacheForDir = cachedIgnores.get(dir);
       if (cacheForDir) {
+        // fast-glob doesn't support negated patterns in `ignore` (i.e. unignores are.. ignored): https://github.com/mrmlnc/fast-glob/issues/86
         ignore.push(...cacheForDir.ignores);
-        ignore.push(...cacheForDir.unignores.map(pattern => `!${pattern}`));
       }
       // biome-ignore lint/suspicious/noAssignInExpressions: deal with it
       dir = dirname((prev = dir));