Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reveal-md to ES modules and updated all dependencies #465

Merged
merged 3 commits into from
Nov 5, 2023

Conversation

MartenBE
Copy link
Contributor

@MartenBE MartenBE commented Nov 3, 2023

This is a PR to facilitate the upgrade to Reveal.js 5.0.0 as mentioned in #462 and hakimel/reveal.js#3517 . Although Reveal.js hasn't been updated in this PR, all the rest has.

Normally, there should be no or very small breaking changes. All the unit tests and my personal use case work as expected, but I can't test everything and everyway reveal-md has been used, and many files have been edited in some way in the code base.

@webpro webpro merged commit 7c49612 into webpro:main Nov 5, 2023
@webpro
Copy link
Owner

webpro commented Nov 5, 2023

Martijn, you're a legend! Thanks a bunch for this 🙏

@webpro
Copy link
Owner

webpro commented Nov 5, 2023

Didn't catch that we jumped to Node.js v20, tweaked that down a bit to v18 (it's not EOL).

@webpro
Copy link
Owner

webpro commented Nov 5, 2023

Did a prerelease v6.0.0-next.0 with the next npm dist tag. So things can be tested and verified a bit, perhaps include reveal.js v5 as well, before we release reveal-md v6.

@MartenBE
Copy link
Contributor Author

MartenBE commented Nov 5, 2023

Wow, thanks! Didn't expect this so soon!

Unfortunately, as I posted the issue at the repo for reveal.js itself, it seems that we won't be able to call functions on the Markdown plugin anymore. We will probably have to rethink the whole render logic. I have some ideas (such as not calling the render funcxtions ourselves but transpile to https://revealjs.com/markdown/#external-markdown ), but it will take some time and experimentation to get (hopefully) something working.

PS: I also don't come from a frontend background (mainly C++ and Java), so this should definitely be tested through first by people with more uses cases.

@webpro
Copy link
Owner

webpro commented Nov 6, 2023

Unfortunately, as I posted the issue at the repo for reveal.js itself, it seems that we won't be able to call functions on the Markdown plugin anymore.

More ideas: depending on their output, we might be able to make it easier and still hack do so using createRequire or even transform using something like jiti

PS: I also don't come from a frontend background (mainly C++ and Java)

That explains the typo in the title of 706394e (no worries j/k)

Again, thanks for your work, it is honestly much appreciated.

@MartenBE
Copy link
Contributor Author

MartenBE commented Nov 6, 2023

According to hakimel/reveal.js#3517 (comment) we seem to be able to use the current implementation a bit longer :) This allows us to take our time to cook up a future proof solution.

@MartenBE MartenBE deleted the update-reveal-5.0.0 branch December 4, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants