Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The wikipedia mirror website replay erro #123

Closed
Mingmingshuai opened this issue Dec 12, 2022 · 6 comments
Closed

The wikipedia mirror website replay erro #123

Mingmingshuai opened this issue Dec 12, 2022 · 6 comments

Comments

@Mingmingshuai
Copy link

As you can see , the recording process is right.
image

After Saving the website of the wikipwdia mirror, the replaywebsite exe and online review website both can't show the site , there is only blank interface, showing the loading status。
image
@ikreymer
Copy link
Member

@Mingmingshuai can you provide a sample WACZ file for testing?
The recording works with live Wikipedia itself and I do not have access to that mirror to test.

@Mingmingshuai
Copy link
Author

Thanks for your response, the site address is : https://en.wikipedia.wmmirror.live/wiki/Main_Page.
Here is the WACZ file.
Cryocooler-wiki.zip

ikreymer added a commit to webrecorder/wombat that referenced this issue Dec 15, 2022
@ikreymer
location: make window.location.reload() a nop in wombat - no particul…
63c2361 
…arly good reason to reload, as wombat attempts to avoid any persistent state across reloads, so cleared, and could result in an infinite reload loop (fixes issue in webrecorder/archiveweb.page#123)
@ikreymer
Copy link
Member

Thanks, it seems like this mirror has a check where it attempts to check localStorage.getItem() and if an object isn't set, it sets it with localStorage.setItem() and then calls window.location.reload(). Since this is an archive, its not persisting local storage, so this causes an infinite reload loop. To avoid, this probably best solution is just to disable window.location.reload() altogether, as it likely only leads to negative behavior in an archive, since there should be no persistent state...

This will be fixed in an updated version of replayweb.page / archiveweb.page soon. The above archive does work in replayweb.page with the updated wombat.js

ikreymer added a commit to webrecorder/wombat that referenced this issue Dec 15, 2022
@ikreymer
Location Fixes (#105)
7f6987f 
* location: rewrite: resolve relative URLs correctly, using the URL class (should fix webrecorder/pywb#789)

* location: override: make window.location.reload() a nop in wombat - no particularly good reason to reload, as wombat attempts to avoid any persistent state across reloads, so cleared, and could result in an infinite reload loop (fixes issue in webrecorder/archiveweb.page#123)

* tests: fix reload test to test for *not* reloading
@ikreymer ikreymer mentioned this issue Dec 17, 2022
Merged
@ikreymer
Copy link
Member

Replay issue, fixed in replayweb.page 1.7.9, will be in next release of archiveweb.page

@Mingmingshuai
Copy link
Author

Thanks for your kindly solution.

@ikreymer
Copy link
Member

Fixed in 0.9.4 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ikreymer @Mingmingshuai