Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate archived item page count out from size #2334

Closed
SuaYoo opened this issue Jan 22, 2025 · 0 comments · Fixed by #2364
Closed

Separate archived item page count out from size #2334

SuaYoo opened this issue Jan 22, 2025 · 0 comments · Fixed by #2364
Assignees
@SuaYoo
Labels
enhancement New feature or request front end Requires front end dev work

Comments

@SuaYoo
Copy link
Member

SuaYoo commented Jan 22, 2025

What change would you like to see?

The archived item overflow should separate page count from the "Size" label since they're distinct counts.

Image

Context

Following #2327 we'll also have uniquePageCount that could be displayed for archived items.
@SuaYoo SuaYoo added enhancement New feature or request front end Requires front end dev work labels Jan 22, 2025
@SuaYoo SuaYoo self-assigned this Jan 22, 2025
@ikreymer ikreymer moved this from Triage to Todo in Webrecorder Projects Jan 22, 2025
@SuaYoo SuaYoo moved this from Todo to Ready in Webrecorder Projects Feb 5, 2025
@SuaYoo SuaYoo moved this from Ready to In Design in Webrecorder Projects Feb 5, 2025
@SuaYoo SuaYoo moved this from In Design to Implementing in Webrecorder Projects Feb 5, 2025
@SuaYoo SuaYoo mentioned this issue Feb 5, 2025
Merged
@SuaYoo SuaYoo changed the title [Feature]: Separate archived item page count out from size Separate archived item page count out from size Feb 5, 2025
@SuaYoo SuaYoo moved this from Implementing to In Review in Webrecorder Projects Feb 5, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done! in Webrecorder Projects Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SuaYoo SuaYoo

Labels
enhancement New feature or request front end Requires front end dev work
Projects
Webrecorder Projects
Status: Done!
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: More accurate archived item details webrecorder/browsertrix
1 participant
@SuaYoo