fix: More accurate archived item details #2364
Conversation
SuaYoo
changed the title
| })}${this.item.stats?.done | ||
| ? html`<span>,</span | ||
| ><span | ||
| class="tracking-tighter${this.isActive | ||
| ? " text-violet-600" | ||
| : ""} font-mono" | ||
| > | ||
| ${this.localize.number(+this.item.stats.done)} | ||
| <span class="text-0-400">/</span> | ||
| ${this.localize.number(+this.item.stats.found)} | ||
| </span> | ||
| <span | ||
| >${pluralOf("pages", +this.item.stats.found)}</span | ||
| >` |
There was a problem hiding this comment.
The logic here enabled us to show the current page count (out of total queued and done) for running crawls - might be worth keeping that in? Otherwise it's hard to know when you're deep in a crawl detail for a running crawl how far along that crawl is.
There was a problem hiding this comment.
Hmm, good catch, this highlights a larger UX issue. I thought this was a leftover from when we migrated towards showing crawl status only in workflows, but we do link to active crawls from the workflow crawl list... I think this was originally an oversight, but it seems like the natural inclination is to see crawl status from the archived item page. Do we want to continue to support this? @Shrinks99 ?
There was a problem hiding this comment.
Gah, yeah this is a left over that I've been meaning to bring up for a long time!
I would like to remove this to keep the "workflow produces an archived item" concept intact. There isn't much one can do in an archived item that is currently being crawled, and as far as users are concerned an archived item shouldn't exist until a crawl is stopped, canceled, or completes.
Resolves #2334
Changes
Screenshots