-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuring available languages from helm chart #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emma-sg
force-pushed
the
i18n-hardcode-locales
branch
2 times, most recently
from
December 11, 2024 02:43
1745c06
to
824748f
Compare
Signed-off-by: emma <hi@emma.cafe>
Signed-off-by: emma <hi@emma.cafe>
Signed-off-by: emma <hi@emma.cafe>
Signed-off-by: emma <hi@emma.cafe>
Signed-off-by: emma <hi@emma.cafe>
Signed-off-by: emma <hi@emma.cafe>
Signed-off-by: emma <hi@emma.cafe>
Signed-off-by: emma <hi@emma.cafe>
uses a ponyfilled `Intl.LocaleMatcher` to match against the available languages, and ensures that the list of available languages is present at first load by explicitly loading app settings before initializing language.
…t locale is used
emma-sg
force-pushed
the
i18n-hardcode-locales
branch
from
December 12, 2024 20:06
dd3b07c
to
f723ce2
Compare
Documenting this in case it comes up again: for whatever reason we were getting CORS errors in Playwright trying to call API endpoints that were proxied, which caused the page to never complete loading. Adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2223
localesAvailable
to/api/settings
endpoint, and uses that list if available, rather than the full list of translated locales, to determine which options to display to usersUses the user's browser locales, filtered to the current language setting, for formatting numbers, dates, and durationssl-format-bytes
withlocalize.bytes(...)
, andsl-format-date
with replacementbtrix-format-date
that properly handles fallback localesScreen.Recording.2024-12-12.at.7.09.32.PM.mov